Created attachment 184611 [details] up to 3.0.3.1
make package ok. editors/codelite run OK after rebuild
Waiting for maintainer feedback to start an exp-run.
Hi, I have some doubts about the patch submitted, why use the git hash when the version number is enough. I push a review for this upgrade. https://reviews.freebsd.org/D11907
Long hash is more clear to me instead short hash or version number.
The porter's handbook says that if a tag is present, use it and not the commit hash. Section 5.4.3. https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html
@mat thanks for the reference, I'm fine with that. @rozhuk Just to clarify I didn't make a review to fix your PR, I was preparing an upgrade for this port then I realize I was doing a duplicate issue. It was not intentional. Hope this fix will be committed soon ;)
Created attachment 185617 [details] change git hash to port version tag
ping
(Also, USE_GITHUB and such appear way too early in the Makefile)
Created attachment 187866 [details] fix build
(In reply to rozhuk.im from comment #10) > Created attachment 187866 [details] > fix build This looks good to me. I regret I can't test it locally, as my dev box is buggered ATM. Consider this "maintainer approval", and THANKS for all the work you've done on this! --Chris
Are you sure about: -NLS_USES= gettext +NLS_USES= gettext-tools % pkg rquery %B wx30-gtk2 | grep intl libintl.so.8
(In reply to Antoine Brodin from comment #12) Not sure. I think you are right.
What is the reason for overriding DISTNAME too? It shouldn't be needed.
Created attachment 188077 [details] proposed patch for exp-run NLS_USES=gettext was put back and DISTNAME override was removed.
There are 3 new failures: math/saga security/veracrypt sysutils/passwordsafe New failure logs: http://package22.nyi.freebsd.org/data/110amd64-default-PR220932/2017-11-18_06h57m32s/logs/saga-4.1.0_2.log http://package22.nyi.freebsd.org/data/110amd64-default-PR220932/2017-11-18_06h57m32s/logs/veracrypt-1.21.log http://package22.nyi.freebsd.org/data/110amd64-default-PR220932/2017-11-18_06h57m32s/logs/passwordsafe-1.02.1.b.log http://package23.nyi.freebsd.org/data/110i386-default-PR220932/2017-11-18_06h57m24s/logs/saga-4.1.0_2.log http://package23.nyi.freebsd.org/data/110i386-default-PR220932/2017-11-18_06h57m24s/logs/veracrypt-1.21.log http://package23.nyi.freebsd.org/data/110i386-default-PR220932/2017-11-18_06h57m24s/logs/passwordsafe-1.02.1.b.log
I have broken OpenCV 3.3 and cant test build math/saga, but patch should be easy, I describe it in comment: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223758
Created attachment 188476 [details] merge with latest changes
Waiting to depends apply pathes...
Created attachment 188688 [details] Patch 1 from 2 for math/saga to work with x11-toolkits/wxgtk30 3.0.3.1 As described in bug #223758, comment #5, there is already an upstream patch for SAGA GIS trunk version. This will land in release version > 6.1.0, this may take some time. Until than, these changes should be applied to the SAGA GIS port (math/saga) via two patches for the files dir.
Created attachment 188689 [details] Patch 2 from 2 for math/saga to work with x11-toolkits/wxgtk30 3.0.3.1
A commit references this bug: Author: jbeich Date: Wed May 2 23:33:30 UTC 2018 New revision: 468894 URL: https://svnweb.freebsd.org/changeset/ports/468894 Log: x11-toolkits/wxgtk30: update to 3.0.3.1 Changes: https://github.com/wxWidgets/wxWidgets/blob/v3.0.3/docs/readme.txt ABI: https://abi-laboratory.pro/tracker/timeline/wxwidgets/ PR: 220932 Submitted by: rozhuk.im@gmail.com Approved by: Chris Hutchinson (maintainer) Reviewed by: antoine, mat Exp-run by: antoine Changes: head/x11-toolkits/wxgtk30/Makefile head/x11-toolkits/wxgtk30/distinfo head/x11-toolkits/wxgtk30/files/patch-src_stc_scintilla_src_Editor.cxx head/x11-toolkits/wxgtk30/pkg-plist
Thanks. Landed with minor style changes.