Created attachment 184648 [details] patch Hans, Please verify that it works. Passes poudriere, starts, but I don't have any working midi devices as of yet. Yuri
Created attachment 184651 [details] patch Fixed examples. Doesn't find banks for some reason.
I'll try to have a look at this in a few days. --HPS
Ping - Working on this PR
Basically your patches are OK. I'm working on some fixes for a 3.0.3 release which make your patches in files/ redundant. Stay tuned!
Okay!
OK, Can you remove your zynaddsubfx patches and instead set the following CMAKE variables when building: ZYN_EXAMPLESDIR:STRING=/usr/local/share/examples/zynaddsubfx ZYN_DATADIR:STRING=/usr/local/share/zynaddsubfx And wait for the 3.0.3 release? --HPS
(In reply to Hans Petter Selasky from comment #6) Thanks Hans, I will just wait until 3.0.3, no rush. Yuri
Hi, 3.0.3 is out now. Could you update your patch? Some patches should now be redundant. --HPS
From what I can see you don't need to patch any sources. It is building fine with clang AS-IS over here. Can you re-evaluate all patches?
Created attachment 187880 [details] patch-3.0.3 Patch for 3.0.3 - to be released very soon.
Created attachment 188577 [details] Update zynaddsubfx port The 3.0.3 release is finally out. Update patch to build zynaddsubfx.
testbuilds@work, portlint is OK
testbuild logs see http://people.freebsd.org/~pi/logs/audio__zynaddsubfx-10i-1512551986.txt http://people.freebsd.org/~pi/logs/audio__zynaddsubfx-111-1512551986.txt http://people.freebsd.org/~pi/logs/audio__zynaddsubfx-cur-1512551986.txt Please note: Failed to build on 10i, cur.
A commit references this bug: Author: hselasky Date: Wed Dec 6 09:57:32 UTC 2017 New revision: 455641 URL: https://svnweb.freebsd.org/changeset/ports/455641 Log: Update ZynAddSubFx to v3.0.3. This update include many bugfixes and many new features over v2.4.3. The list of changes would be too long for this commit message. Please refer to the ZynAddSubFx release announcements at zynaddsubfx-user@lists.sourceforge.net for more information. PR: 220958 PR: 223635 Tested by: pi @ Approved by: maintainer Changes: head/audio/zynaddsubfx/Makefile head/audio/zynaddsubfx/distinfo head/audio/zynaddsubfx/files/ head/audio/zynaddsubfx/pkg-plist
Looks like I missed your build logs :-(
This chunk should fix it, until someone can iron out the compiler issues. --HPS Index: Makefile =================================================================== --- Makefile (revision 455641) +++ Makefile (working copy) @@ -106,4 +106,11 @@ ${INSTALL_DATA} ${DOC_FILES2:S|^|${DOCSRCDIR2}/|} ${STAGEDIR}${DOCSDIR2} ${INSTALL_DATA} ${DOC_FILES3:S|^|${DOCSRCDIR3}/|} ${STAGEDIR}${DOCSDIR3} +.include <bsd.port.options.mk> + +# Build fix for ZynAddSubFx +BUILD_DEPENDS+= clang40:devel/llvm40 +CC= clang40 +CXX= clang++40 + .include <bsd.port.post.mk>
A commit references this bug: Author: pi Date: Wed Dec 6 17:30:06 UTC 2017 New revision: 455665 URL: https://svnweb.freebsd.org/changeset/ports/455665 Log: audio/zynaddsubfx: fix build on cur, 10.x by force llvm40 PR: 220958 Submitted by: hselasky (maintainer) Changes: head/audio/zynaddsubfx/Makefile