Bug 221058 - graphics/luminance: Update to 2.5.1
Summary: graphics/luminance: Update to 2.5.1
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Hannes Hauswedell
URL:
Keywords: needs-patch
Depends on: 212817
Blocks:
  Show dependency treegraph
 
Reported: 2017-07-28 02:54 UTC by goffredo
Modified: 2019-01-09 20:12 UTC (History)
5 users (show)

See Also:
linimon: maintainer-feedback? (h2+fbsdports)


Attachments
Luminance-qt5 2.5.1 port (2.88 KB, application/octet-stream)
2017-08-20 16:14 UTC, goffredo
no flags Details
Makefile diff from Luminance HDR 2.4.0 to 2.5.1 (1.60 KB, text/plain)
2017-08-20 17:22 UTC, goffredo
no flags Details
Fixing a bug in Makefile (2.41 KB, text/plain)
2017-09-13 02:52 UTC, goffredo
no flags Details
snv-diff (7.67 KB, text/plain)
2017-09-13 05:05 UTC, goffredo
no flags Details
Makefile again. (1.69 KB, text/plain)
2017-09-15 05:03 UTC, goffredo
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description goffredo 2017-07-28 02:54:43 UTC
There is a new version of Luminance HDR. In ports is 2.4.0, but it is in 2.5.1 version.

I attempted to update the port, but had a problem with QT-Web.

Can you update the port, or help me with this QT problem?
Comment 1 Hannes Hauswedell 2017-07-30 19:29:53 UTC
Hi goffredo,

sorry for not replying to your e-email earlier. Updating this port requires qt5-webengine which is not available on FreeBSD, yet, see #212817

@linimon: can you set this bug to "depends on 212817"?

Thanks,
Hannes
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2017-08-01 08:34:52 UTC
CC qt* maintainers
Comment 3 Tobias C. Berner freebsd_committer 2017-08-17 19:14:20 UTC
Hi. 

qt5-webengine has now landed in ports r448132. 


mfg Tobias
Comment 4 goffredo 2017-08-20 16:14:25 UTC
Created attachment 185607 [details]
Luminance-qt5 2.5.1 port

This is the Luminance HDR 2.5.1 port.

Verify if it is Ok. I don't have many experience making ports.

It is working in my computer.

Thanks.
Comment 5 Tobias C. Berner freebsd_committer 2017-08-20 16:20:59 UTC
Hi there

Could you upload it as a diff?


mfg Tobias
Comment 6 goffredo 2017-08-20 17:18:30 UTC
The "pkg-plist" and "distinfo" files are new.

There isn't files in "files" directory.

It is easy to create Makefile diff. See bellow.

root:SUPER[1179] diff luminance-qt5/Makefile luminance-qt5_2.5.1/Makefile 
5,6c5,6
< DISTVERSION=  2.4.0
< PORTREVISION= 16
---
> DISTVERSION=  2.5.1
> PORTREVISION= 17
17,19c17,21
< LIB_DEPENDS=  libfftw3f.so:math/fftw3-float \
<               libexiv2.so:graphics/exiv2 \
<               libIlmImf.so:graphics/OpenEXR \
---
> LIB_DEPENDS=  libcfitsio.so:astro/cfitsio \
>               libHalf.so:graphics/ilmbase \
>               libIex-2_2.so:graphics/ilmbase \
>               libIlmThread-2_2.so:graphics/ilmbase \
>               libImath-2_2.so:graphics/ilmbase \
21d22
<               libgsl.so:math/gsl \
23c24,35
<               libboost_system.so:devel/boost-libs
---
>               libfftw3f.so:math/fftw3-float \
>               libfftw3f_threads.so:math/fftw3-float \
>               libgsl.so:math/gsl \
>               libgslcblas.so:math/gsl \
>               libexiv2.so:graphics/exiv2 \
>               liblcms2.so:graphics/lcms2 \
>               libpng16.so:graphics/png \
>               libboost_program_options.so:devel/boost-libs \
>               libboost_thread.so:devel/boost-libs \
>               libboost_chrono.so:devel/boost-libs \
>               libboost_system.so:devel/boost-libs \
>               libboost_date_time.so:devel/boost-libs
25,28c37,40
< USES=         cmake:outsource jpeg pkgconfig tar:bzip2
< USE_QT5=      concurrent gui printsupport sql webkit xml \
<               buildtools_build linguist_build qmake_build \
<               imageformats_run
---
> USES=         cmake:outsource jpeg pkgconfig tar:bzip2 desktop-file-utils
> USE_QT5=      printsupport xml sql webengine webchannel location \
>               quick qml network widgets concurrent gui core
>
Comment 7 goffredo 2017-08-20 17:22:51 UTC
Created attachment 185610 [details]
Makefile diff from Luminance HDR 2.4.0 to 2.5.1

Makefile diff from Luminance HDR 2.4.0 to 2.5.1

Sending as attachment.
Comment 8 goffredo 2017-09-13 02:52:02 UTC
Created attachment 186315 [details]
Fixing a bug in Makefile

There is a small bug in Makefile. I fixed it. This is the new version.
Comment 9 Tobias C. Berner freebsd_committer 2017-09-13 04:56:43 UTC
Hi there

Could you attach the changes as an (svn-)diff -- that makes it much easier to see what you do :)
[ svn diff graphics/luminance-qt5 ]

You should also be able to get rid of the "Qt5 declarative" hackery :)


mfg Tobias
Comment 10 goffredo 2017-09-13 05:05:08 UTC
Created attachment 186317 [details]
snv-diff

I attached svn-diff file.
Comment 11 Tobias C. Berner freebsd_committer 2017-09-13 05:14:55 UTC
Thanks :)


1) you can get rid of PORTREVISION (as PORTVERSION is incremented)
   (see 5.2.3 in [1])

2) the post-patch target can/should be modified slightly:
   - get rid of the declarative part
   - get rid of the git-hash part, or update the checksum 

3) the pre-install target looks weird

4) probably MAKE_JOBS_UNSAFE can go away

5) depending on boost-libs once is enough

6) don't LIB_DEPEND on qt5-svg -- it's already added via USE_QT5=svg





[1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html
Comment 12 goffredo 2017-09-15 05:01:24 UTC
I modified the Makefile, and got this error:

"
Error: /usr/local/bin/luminance-hdr is linked to /usr/local/lib/libIlmImf-2_2.so.22 from graphics/OpenEXR but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libIlmImf-2_2.so:graphics/OpenEXR
"

It installs e works fine.

But, when I add libIlmImf-2_2.so:graphics/OpenEXR in LIB_DEPENDS I get this error:

"
===>   luminance-hdr-qt5-2.5.1 depends on shared library: libIlmImf-2_2.so - not found
===>  OpenEXR-2.2.0_7 has known vulnerabilities:
OpenEXR-2.2.0_7 is vulnerable:
OpenEXR -- multiple remote code execution and denial of service vulnerabilities
CVE: CVE-2017-9116
CVE: CVE-2017-9115
CVE: CVE-2017-9114
CVE: CVE-2017-9113
CVE: CVE-2017-9112
CVE: CVE-2017-9111
CVE: CVE-2017-9110
WWW: https://vuxml.FreeBSD.org/freebsd/803879e9-4195-11e7-9b08-080027ef73ec.html

1 problem(s) in the installed packages found.
=> Please update your ports tree and try again.
=> Note: Vulnerable ports are marked as such even if there is no update available.
=> If you wish to ignore this vulnerability rebuild with 'make DISABLE_VULNERABILITIES=yes'
*** Error code 1

Stop.
make[3]: stopped in /usr/ports/graphics/OpenEXR
*** Error code 1

Stop.
make[2]: stopped in /usr/ports/graphics/OpenEXR
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/graphics/luminance-qt5
*** Error code 1

Stop.
make: stopped in /usr/ports/graphics/luminance-qt5
"

I know, there is this security issue in OpenEXR. And they know (https://github.com/openexr/openexr/issues/232). I sent this security issue message to then.

But I have it installed:

"
root:SUPER[1068] pkg info | grep -i openexr
OpenEXR-2.2.0_7                High dynamic-range (HDR) image file format
"
Comment 13 goffredo 2017-09-15 05:03:23 UTC
Created attachment 186406 [details]
Makefile again.

This is the new version.
Comment 14 Tobias C. Berner freebsd_committer 2017-09-15 05:39:15 UTC
(In reply to goffredo from comment #13)

Thanks :)


[Always] upload diffs =) -- and you can mark the old ones to be obsolete.

1)
There is a 
   OPTIONS_DEFINE=	DOCS
however no handling of it -- so you could look into fixing that too, while you're there :)

2)
Also you need to add back the various <foo>_build items to USE_QT5. 
  * qmake_build <-- gives you the qmake binary, needed by cmake' Qt5 module
  * buildtools_build 
  * linguisttools_build (should probably work instead of linguist_build)

3)
You probably need to re-add the LIB_DEPENDS on graphics/OpenEXR

4) 
There are some other multiple LIB_DEPENDS on the same port -- that could be sipmlified too, imho.


mfg Tobias
Comment 15 kunda 2019-01-09 20:12:45 UTC
Any progress on this?