Bug 221098 - [NEW PORT] science/Trilinos: Framework for solution for engineering and scientific problems
Summary: [NEW PORT] science/Trilinos: Framework for solution for engineering and scien...
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL: https://github.com/trilinos/Trilinos/
Keywords: feature, needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2017-07-30 01:20 UTC by jsmith
Modified: 2018-05-23 15:46 UTC (History)
3 users (show)

See Also:
yuri: maintainer-feedback+


Attachments
Initial shar of port (76.26 KB, text/plain)
2017-07-30 01:20 UTC, jsmith
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description jsmith 2017-07-30 01:20:49 UTC
Created attachment 184838 [details]
Initial shar of port

This is a new port for the Trilinos project. 

Description: The Trilinos Project is an effort to develop algorithms and enabling technologies within an object-oriented software framework for the solution of large-scale, complex multi-physics engineering and scientific problems. A unique design feature of Trilinos is its focus on packages.

Website: https://github.com/trilinos/Trilinos/

This port is on the FreeBSD Ports Wanted wiki page.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2017-08-01 06:13:57 UTC
Thank you for fulfilling a WantedPorts request
Comment 2 Yuri Victorovich freebsd_committer 2017-08-04 21:04:31 UTC
Please fix these errors:

# portlint -A
WARN: /usr/ports/science/trilinos/pkg-descr: includes lines that exceed 80 characters.
FATAL: Makefile: [1]: incorrect header; use Created by: with a single space, then $FreeBSD$.
WARN: Makefile: COMMENT is not supposed to begin with 'A ', 'An ', or 'The '.
FATAL: Makefile: non-comment line in comment section.
FATAL: Makefile: no $FreeBSD$ line in comment section.
FATAL: Makefile: extra item "MAINTAINER" placed in the PORTNAME section.
FATAL: Makefile: extra item "COMMENT" placed in the PORTNAME section.
FATAL: Makefile: PORTNAME has to be there.
WARN: Makefile: PORTVERSION/DISTVERSION is set externally to this port's Makefile, but this port is not configured as a slave port.
WARN: Makefile: CATEGORIES is set externally to this port's Makefile, but this port is not configured as a slave port.
FATAL: Makefile: extra item "LICENSE" placed in the MAINTAINER section.
FATAL: Makefile: extra item "LICENSE_COMB" placed in the MAINTAINER section.
WARN: Makefile: COMMENT is set externally to this port's Makefile, but this port is not configured as a slave port.
FATAL: Makefile: extra item "USES" placed in the LICENSE section.
FATAL: Makefile: extra item "CMAKE_ARGS" placed in the LICENSE section.
WARN: Consider to set DEVELOPER=yes in /etc/make.conf
10 fatal errors and 6 warnings found.
Comment 3 Yuri Victorovich freebsd_committer 2017-08-04 21:11:05 UTC
Also, please fix these errors:

# make stage-qa
====> Running Q/A tests (stage-qa)
Error: '/bin/bash' is an invalid shebang you need USES=shebangfix for 'bin/nvcc_wrapper'
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'bin/phalanx_create_evaluator.py'
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'lib/cmake/tribits/python_utils/gitdist.py'
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'lib/cmake/tribits/python_utils/snapshot-dir.py'
*** Error code 1

Bash should be either made a RUN_DEPENDS, if it is essential, or replaced with /bin/sh if Bourne shell can run it.

USE=python is missing. Please also determine is any python works, or only python3, or only python3.
Comment 4 Yuri Victorovich freebsd_committer 2017-08-04 21:14:00 UTC
Also, why do you disable Fortran? (-DTrilinos_ENABLE_Fortran:BOOL=OFF) It should be made a port option. Same with Trilinos_ENABLE_OpenMP.
Comment 5 Yuri Victorovich freebsd_committer 2017-08-04 21:21:23 UTC
Please make it build dynamic libraries along with, or instead of static ones. Dynamic libraries should be preferred.

It fails to build in poudriere. Please always build ports in poudriere before submitting.[1] Poudriere fails to find x11, but stage-qa doesn't complain about x11. This is likely because their CMakeLists.txt requires it but doesn't actually use it, which is the bug in Trilinos if true. Upstream bugs need to be reported when found.

[1] https://www.freebsd.org/doc/handbook/ports-poudriere.html
Comment 6 Eitan Adler freebsd_committer freebsd_triage 2018-05-23 10:27:32 UTC
batch change of PRs untouched in 2018 marked "in progress" back to open.
Comment 7 Yuri Victorovich freebsd_committer 2018-05-23 15:46:15 UTC
I tried to make the port for the whole Trilinos, not just a ortion of it as the submitted patch did, and couldn't yet make the rest build. Will come back to it.