Bug 221113 - textproc/fzf: Add shell examples directory
Summary: textproc/fzf: Add shell examples directory
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Richard Gallamore
Keywords: easy, needs-qa
Depends on:
Reported: 2017-07-31 08:19 UTC by Sascha Holzleiter
Modified: 2017-08-08 22:07 UTC (History)
1 user (show)

See Also:

fzf shell examples patch (1.55 KB, patch)
2017-07-31 08:19 UTC, Sascha Holzleiter
sascha: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha Holzleiter 2017-07-31 08:19:00 UTC
Created attachment 184863 [details]
fzf shell examples patch

The following patch adds %%EXAMPLESDIR%%/shell with various key bindings and completion files for bash, fish and zsh. It also adds a pkg-message about it.
(requested by Eugene Z)

While here let the binary be stripped, there is nothing wrong with stripping go binaries.

Also bump portrevision.

portlint: ok
poudriere testport(amd64): ok
Comment 1 commit-hook freebsd_committer 2017-08-08 22:04:36 UTC
A commit references this bug:

Author: ultima
Date: Tue Aug  8 22:03:43 UTC 2017
New revision: 447577
URL: https://svnweb.freebsd.org/changeset/ports/447577

  * Removed strip, stripping go is safe
  * Added examples

  PR:		221113
  Submitted by:	Sascha Holzleiter (maintainer)
  Reviewed by:	matthew (mentor)
  Approved by:	matthew (mentor)
  Differential Revision:	https://reviews.freebsd.org/D11894

Comment 2 Richard Gallamore freebsd_committer 2017-08-08 22:07:43 UTC
Committed, thanks!