Bug 221172 - cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/docsExamples/ksyms.d requires ksyms(4) support and strings(1)
Summary: cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/docsExamples/ksyms.d requ...
Status: Closed Not A Bug
Alias: None
Product: Base System
Classification: Unclassified
Component: tests (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-testing (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-02 10:11 UTC by Enji Cooper
Modified: 2019-01-22 00:07 UTC (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enji Cooper freebsd_committer freebsd_triage 2017-08-02 10:11:06 UTC 
Looking at cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/docsExamples/ksyms.d I see two issues:

1. It requires /dev/ksyms, which means that ksyms(4) needs to be loaded for the test.
2. strings(1) is required, which isn't available on systems where MK_TOOLCHAIN == no.
Comment 1 Li-Wen Hsu freebsd_committer freebsd_triage 2017-08-02 15:16:23 UTC 
I don't see docsExamples installed in /usr/tests/cddl/usr.sbin/dtrace/common.  Is it intended?  From the name it looks like a place to put examples, and the files under this directory don't look like complete test cases.
Comment 2 Mark Johnston freebsd_committer freebsd_triage 2017-08-02 19:09:29 UTC 
(In reply to Li-Wen Hsu from comment #1)
Indeed, they're just toy examples and can't be used as test cases. See for instance the comment in ksyms.d:

    /* Must run "strings -a /dev/ksyms in another shell on the system */
Comment 3 Li-Wen Hsu freebsd_committer freebsd_triage 2019-01-21 21:49:18 UTC 
I think this one can be closed as "works as intended"?
Comment 4 Mark Johnston freebsd_committer freebsd_triage 2019-01-22 00:07:37 UTC 
(In reply to Li-Wen Hsu from comment #3)
Yeah, I think that's reasonable.  "Not a bug" seems more accurate though, since there's no actual functionality here that "works as intended", or otherwise. :)
docsExamples are not functional tests.