Created attachment 184956 [details]
Knot-resolver 1.3.2 contains security updates, bugfixes and improvements.
Comment on attachment 184956 [details]
Forget to mention it was successfully tested in Poudriere.
Created attachment 185016 [details]
Fix various issues in previous patch
I noticed some of the options settings weren't doing anything, and then one thing led to another. What do you think of this updated patch?
I renamed the 'STATS' option to 'TRUSTANCHOR' because that seemed to be the important thing that option was controlling. Not convinced that should even be optional though.
Created attachment 185225 [details]
Oh.. (as in oh-oh ). Thanks.
I never noticed as I use the very minimalistic version. Good you did.
So I test your patch against i386 & amd64 on 10.3, 11.0, 11.1 and already on 12.0
And it's all fine.
But while running these tests, 1.3.3 already was released.
So I adjusted against that, ran the same tests again, and again all is fine.
So if you wish to first close this PR then patch 185016 is approved.
If you wish to upgrade straight to 1.3.3 then attached patch is also.
A commit references this bug:
Date: Thu Aug 10 11:53:46 UTC 2017
New revision: 447672
Update to 1.3.3
- fix up OPTIONS processing so that
- turning off an OPTION does disable the option even in the presence
of the optional dependencies required for it
- add PLIST_FILES where appropriate for each option
- rename the STATS option to TRUSTANCHOR since that's the important
capability that option controls
- strip installed files where appropriate
Submitted by: firstname.lastname@example.org (maintainer)