Bug 221193 - [NEW PORT] audio/zita-convolver: Fast, partitioned convolution engine library
Summary: [NEW PORT] audio/zita-convolver: Fast, partitioned convolution engine library
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Richard Gallamore
URL:
Keywords: feature
Depends on:
Blocks: 221199
  Show dependency treegraph
 
Reported: 2017-08-03 03:26 UTC by Yuri Victorovich
Modified: 2017-08-11 08:29 UTC (History)
1 user (show)

See Also:


Attachments
shar (4.58 KB, text/plain)
2017-08-03 03:26 UTC, Yuri Victorovich
no flags Details
shar (4.71 KB, text/plain)
2017-08-03 05:29 UTC, Yuri Victorovich
no flags Details
shar (4.48 KB, text/plain)
2017-08-11 07:03 UTC, Yuri Victorovich
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer 2017-08-03 03:26:29 UTC
Created attachment 184976 [details]
shar

QAs:
* pourdriere
* portlint (gives a bogus error, reported upstream)
Comment 1 Yuri Victorovich freebsd_committer 2017-08-03 05:29:29 UTC
Created attachment 184978 [details]
shar
Comment 2 Richard Gallamore freebsd_committer 2017-08-11 00:56:26 UTC
Looks great as well!

Couple things,

* Modifying the CPPFLAGS and _DEP in patch-Makefile was not necessary and is preferred not to as it will be higher maintenance in the long run. Localbase fixes CPPFLAGS and adding the arg :ldflags to it will fix the other problem that was added with _dep

* As the last I reviewed, one lib needed to be striped.

Added fixes thanks for your contributions and high quality patches. Provide a little more information on QA would be nice. If no one else koobs would surely appreciate it as would I. =]
Comment 3 Yuri Victorovich freebsd_committer 2017-08-11 07:03:53 UTC
Created attachment 185271 [details]
shar

Fixed all mentioned issues.
Comment 4 commit-hook freebsd_committer 2017-08-11 08:26:51 UTC
A commit references this bug:

Author: ultima
Date: Fri Aug 11 08:26:32 UTC 2017
New revision: 447743
URL: https://svnweb.freebsd.org/changeset/ports/447743

Log:
  A C++ library implementing a real-time convolution matrix for up to 64 inputs
  and outputs. It uses multiple partition sizes to provide both low delay and
  efficient CPU use.

  WWW: http://kokkinizita.linuxaudio.org/linuxaudio/

  PR:		221193
  Submitted by:	Yuri Victorovich (maintainer)
  Reviewed by:	matthew (mentor)
  Approved by:	matthew (mentor)
  Differential Revision:	https://reviews.freebsd.org/D11973

Changes:
  head/audio/Makefile
  head/audio/zita-convolver/
  head/audio/zita-convolver/Makefile
  head/audio/zita-convolver/distinfo
  head/audio/zita-convolver/files/
  head/audio/zita-convolver/files/patch-Makefile
  head/audio/zita-convolver/pkg-descr
Comment 5 Richard Gallamore freebsd_committer 2017-08-11 08:29:07 UTC
Committed, thanks!