Bug 221272 - [NEW PORT] audio/lvtk: Wraps the LV2 C API and extensions into easy to use C++ classes
Summary: [NEW PORT] audio/lvtk: Wraps the LV2 C API and extensions into easy to use C+...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Richard Gallamore
URL:
Keywords: feature
Depends on:
Blocks:
 
Reported: 2017-08-06 08:27 UTC by Yuri Victorovich
Modified: 2017-08-13 22:38 UTC (History)
1 user (show)

See Also:

Attachments
shar (3.09 KB, text/plain)
2017-08-06 08:27 UTC, Yuri Victorovich 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2017-08-06 08:27:36 UTC 
Created attachment 185077 [details]
shar

QAs:
* pourdriere 11.1 amd64
* portlint
Comment 1 Richard Gallamore freebsd_committer freebsd_triage 2017-08-12 08:20:17 UTC 
The port looks great except for one item. The port shows version 1.2.0, but is on a different commit tag. Decide to use the tagged release versions or commits as versioning. If the commit route is chosen, please use the date scheme for updates, ex. g20170812.
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2017-08-12 08:49:17 UTC 
(In reply to Richard Gallamore from comment #1)

Your approach has a problem. The tag is added to prevent using a very old code. We can drop revision, and switch to date, but what if tomorrow they will make another release? Then we will have to increment PORTEPOCH again and again. Overtime this will cause PORTEPOCH growth.

Upstreams sometimes release versions regularly, and then stop for a year or two, then become regular again. Examples: devel/google-perftools, textproc/jq, audio/jack.

Setting GH_TAGNAME still preserves the same general version, just moves it to some degree. PORTREVISION can be used to track particular tagname.
Comment 3 Richard Gallamore freebsd_committer freebsd_triage 2017-08-12 20:28:54 UTC 
(In reply to Yuri Victorovich from comment #2)
Okay then, being that I don't use this software and know little about it I'll leave this up to you. It should be good to commit, thanks for your contributions. =]
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-08-13 22:34:09 UTC 
A commit references this bug:

Author: ultima
Date: Sun Aug 13 22:34:00 UTC 2017
New revision: 447921
URL: https://svnweb.freebsd.org/changeset/ports/447921

Log:
  This toolkit contains libraries that wrap the LV2 C API and extensions into
  easy to use C++ classes. The original work for this was mostly done by
  Lars Luthman in lv2-c++-tools.

  WWW: https://github.com/lvtk/lvtk

  PR:		221272
  Submitted by:	Yuri Victorovich (maintainer)
  Reviewed by:	matthew (mentor)
  Approved by:	matthew (mentor)
  Differential Revision:	https://reviews.freebsd.org/D12013

Changes:
  head/audio/Makefile
  head/audio/lvtk/
  head/audio/lvtk/Makefile
  head/audio/lvtk/distinfo
  head/audio/lvtk/pkg-descr
  head/audio/lvtk/pkg-plist
Comment 5 Richard Gallamore freebsd_committer freebsd_triage 2017-08-13 22:38:55 UTC 
Committed, thanks!