Bug 221293 - [NEW PORT] devel/libuuid: UUID library from the standard util-linux package
Summary: [NEW PORT] devel/libuuid: UUID library from the standard util-linux package
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://reviews.freebsd.org/D23312
Keywords: feature
Depends on:
Blocks: 251489
  Show dependency treegraph
Reported: 2017-08-06 21:09 UTC by Yuri Victorovich
Modified: 2021-03-20 08:54 UTC (History)
4 users (show)

See Also:

shar (5.71 KB, text/plain)
2017-08-06 21:09 UTC, Yuri Victorovich
no flags Details
shar (3.24 KB, text/plain)
2017-08-06 21:13 UTC, Yuri Victorovich
no flags Details
updated patch (55.29 KB, patch)
2020-01-21 07:38 UTC, Yuri Victorovich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer 2017-08-06 21:09:47 UTC
Created attachment 185102 [details]

Currently some ports depend on UUID library distributed by linux. This dependency is satisfied by misc/e2fsprogs-libuuid, which is a slave port of sysutils/e2fsprogs, which is a set of utilities and library to manipulate an ext2, ext3 or ext4.

Normally, UUID library is distributed by util-linux package, see https://github.com/karelzak/util-linux and https://en.wikipedia.org/wiki/Util-linux

Taking UUID from e2f is wrong, because this isn't where it normally comes from.

I created a new port devel/libuuid which builds only libuuid part of util-linux.

I suggest, exp-run is done after replacing all uses of misc/e2fsprogs-libuuid with devel/libuuid:
> libuuid.so:misc/e2fsprogs-libuuid -> devel/libuuid

I found 21 such ports.

Or, if exp-run isn't considered to be required, this is fine too.

Mat, do you have an opinion?
Comment 1 Yuri Victorovich freebsd_committer 2017-08-06 21:13:16 UTC
Created attachment 185103 [details]
Comment 2 Mathieu Arnold freebsd_committer 2017-08-06 21:16:30 UTC
None at all.
Comment 3 Yuri Victorovich freebsd_committer 2017-08-06 21:26:56 UTC
Then this port should be committed, and the following replacement shouldbe made: libuuid.so:misc/e2fsprogs-libuuid -> libuuid.so:devel/libuuid
Comment 4 Ben Woods freebsd_committer 2018-11-04 09:02:25 UTC
Hi Yuri, any update on this one?
Comment 5 Yuri Victorovich freebsd_committer 2018-11-04 09:05:45 UTC
(In reply to Ben Woods from comment #4)

This needs to be committed, but it will replace e2fsprogs-libuuid that is heavily used. All numerous dependencies need to be retested.

Comment 6 Walter Schwarzenfeld freebsd_triage 2019-08-27 01:00:51 UTC
Any news here?
Comment 7 Tobias C. Berner freebsd_committer 2020-01-20 15:24:31 UTC
Moin moin

Is there any update here? The  x11/fontconfig-2.13.1 upgrade requires libuuid, and having it split out would be nicer.

mfg Tobias
Comment 8 Yuri Victorovich freebsd_committer 2020-01-20 16:27:19 UTC
(In reply to Tobias C. Berner from comment #7)

I'll look if I could install a separate libuuid with a different name first to not conflict with the other one.
Comment 9 Yuri Victorovich freebsd_committer 2020-01-20 16:51:48 UTC
There are 95 ports that depend on libuuid, and the port is trivial.

I'll just replace them all. Will do tonight if there would be no unexpected problems.
Comment 10 Yuri Victorovich freebsd_committer 2020-01-21 06:42:15 UTC
I will rebuild all ports depending on uuid overnight and will commit the change if they succeed.
Comment 11 Antoine Brodin freebsd_committer 2020-01-21 07:28:02 UTC
This port is ugly,  what is the problem with misc/e2fsprogs-libuuid ?
Comment 12 Yuri Victorovich freebsd_committer 2020-01-21 07:38:45 UTC
Created attachment 210908 [details]
updated patch
Comment 13 Yuri Victorovich freebsd_committer 2020-01-21 07:48:41 UTC
(In reply to Antoine Brodin from comment #11)

> This port is ugly,  what is the problem with misc/e2fsprogs-libuuid ?

libuuid is not related to e2fsprogs, yet it is merged with it.
e2fsprogs is filesystem utilities, and libuuid is UUID handling library.
Comment 14 Antoine Brodin freebsd_committer 2020-01-21 09:10:38 UTC
bapt@ has a cleaner patch.
Comment 15 Matthias Andree freebsd_committer 2020-01-21 23:32:36 UTC
Let's see what we get from the -exp run with bapt's 

Note that e2fsprogs-libuuid installs the executables, too. 
We cannot skip them. If licensing is an issue, we could install the executables separately.

I have not checked if libuuid from util-linux has all the features that e2fsprogs's has - but it appears that they might be related and in that case it might become acceptable to commit a modified version of the port (or two ports) and replace e2fsprogs-libuuid.

The precondition is that we do not remove any features (library/daemon/executable operation modes) and a sheer -exp run only reveals build issues, but not many run-time issues, if, say, a programm calls uuid to generate UUIDs.
Comment 16 Baptiste Daroussin freebsd_committer 2020-01-22 09:12:14 UTC
I added my take on what should be done here (see the review URL)

Note that while doing that change, I have also done the same thing for libblkid (not sure we want that, but that is what others are doing as well and the version).
Comment 17 Baptiste Daroussin freebsd_committer 2020-01-22 09:13:36 UTC
(In reply to Matthias Andree from comment #15)
on the binaries added by uuid package, I can probably readd uuidgen, but uuidd is not compatible anymore with FreeBSD (using signalfd), is there a real usage of uuid on FreeBSD working it worth porting it?
Comment 18 Matthias Andree freebsd_committer 2020-02-15 00:50:38 UTC
Since there is no progress and no real argument why we need to go through the hassle, let's kill this effort.
Comment 19 Matthias Andree freebsd_committer 2020-11-30 20:35:44 UTC
reopening because someone actually came up with a good reason to conduct this effort. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251489.
Comment 20 Matthias Andree freebsd_committer 2021-03-20 08:38:17 UTC
(In reply to Baptiste Daroussin from comment #17)
I don't mind losing uuidd for now, but we should plan this properly. 

To that end, I propose to commit this in April or May so it can get a few weeks of exposure before it trickles down into the quarterly branch.

What is the result of -exp run?
Comment 21 Yuri Victorovich freebsd_committer 2021-03-20 08:54:14 UTC
Is this the same libuuid.so that devel/util-linux installs? The UUID part can be split out into a separate port.