Bug 221313 - databases/tile38: Update to 1.9.0
Summary: databases/tile38: Update to 1.9.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Torsten Zuehlsdorff
URL: https://github.com/tidwall/tile38/rel...
Keywords: easy, needs-qa
Depends on:
Reported: 2017-08-07 14:27 UTC by Andreas Andersson
Modified: 2017-08-11 10:28 UTC (History)
3 users (show)

See Also:
olevole: maintainer-feedback+

Update to 1.9.0 (814 bytes, patch)
2017-08-07 14:27 UTC, Andreas Andersson
olevole: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Andersson 2017-08-07 14:27:16 UTC
Created attachment 185130 [details]
Update to 1.9.0

As per olegs wishes I am opening up a new issue. Also attaching diff.

* Update to version 1.9.0
* Update distinfo accordingly.


 * https://github.com/tidwall/tile38/releases/tag/1.9.0
Comment 1 Oleg Ginzburg 2017-08-07 15:00:50 UTC
Comment on attachment 185130 [details]
Update to 1.9.0

I approve this patch
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2017-08-07 15:01:38 UTC
Pending QA (portlint/poudriere) confirmation
Comment 3 Andreas Andersson 2017-08-07 15:27:42 UTC
Builds fine with poudriere testport.

The following warnings are displayed with portlint -AC

WARN: Makefile: possible use of absolute pathname "/var/db/tile38"
WARN: Makefile: possible use of absolute pathname "/var/run/tile38".
WARN: /usr/local/poudriere/ports/default/databases/tile38/distinfo: [1]: TIMESTAMP is over 30 days old

Those absolute path's are defined in variables
 * TILE38_DBDIR?=  /var/db/tile38 
 * TILE38_RUNDIR?= /var/run/tile38

And then referenced like so: 
@${MKDIR} ${STAGEDIR}${TILE38_DBDIR} ${STAGEDIR}${TILE38_RUNDIR} in do-install target.

But nowhere else, not sure this is an issue?

Should I remove distinfo and re-run make makesum in order to remove the TIMESTAMP warning? Or is this still ok?
Comment 4 Andreas Andersson 2017-08-07 15:36:46 UTC
Also been running this in production for the past few months without issues. hence the old timestamp
Comment 5 Oleg Ginzburg 2017-08-07 15:46:30 UTC
(In reply to a.andersson.thn from comment #3)

"Absolute path's are defined in variables warning" is ok here. I guess that should be good.
Comment 6 commit-hook freebsd_committer 2017-08-11 10:22:31 UTC
A commit references this bug:

Author: tz
Date: Fri Aug 11 10:21:44 UTC 2017
New revision: 447752
URL: https://svnweb.freebsd.org/changeset/ports/447752

  databases/tile38: Update from 1.5.2 to 1.9.0

  Changelog: https://github.com/tidwall/tile38/blob/1.9.0/CHANGELOG.md

  PR:           221313
  Submitted by: Andreas Andersson <a.andersson.thn@gmail.com>

Comment 7 Torsten Zuehlsdorff freebsd_committer 2017-08-11 10:28:30 UTC
Committed, thanks :)