Bug 221319 - [NEW PORT] audio/synthpod-lv2: Lightweight Nonlinear LV2 Plugin Container
Summary: [NEW PORT] audio/synthpod-lv2: Lightweight Nonlinear LV2 Plugin Container
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Richard Gallamore
URL:
Keywords: feature
Depends on:
Blocks:
 
Reported: 2017-08-07 19:31 UTC by Yuri Victorovich
Modified: 2017-08-21 07:08 UTC (History)
1 user (show)

See Also:

Attachments
shar (19.43 KB, text/plain)
2017-08-07 19:31 UTC, Yuri Victorovich 		no flags Details
shar (11.50 KB, text/plain)
2017-08-11 07:20 UTC, Yuri Victorovich 		no flags Details
shar (11.45 KB, text/plain)
2017-08-11 07:21 UTC, Yuri Victorovich 		no flags Details
shar (9.11 KB, text/plain)
2017-08-11 07:38 UTC, Yuri Victorovich 		no flags Details
shar (9.17 KB, text/plain)
2017-08-12 22:25 UTC, Yuri Victorovich 		no flags Details
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2017-08-07 19:31:46 UTC 
Created attachment 185136 [details]
shar

QAs:
* poudriere 11.1 amd64
* portlint
* runs fine
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2017-08-11 07:20:28 UTC 
Created attachment 185272 [details]
shar

Upstream adopted our patches, and made some bug fixes.
Updated to the latest version.
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2017-08-11 07:21:23 UTC 
Created attachment 185273 [details]
shar
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2017-08-11 07:38:46 UTC 
Created attachment 185275 [details]
shar
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2017-08-12 22:25:07 UTC 
Created attachment 185336 [details]
shar
Comment 5 Richard Gallamore freebsd_committer freebsd_triage 2017-08-21 02:04:02 UTC 
looks good, had to make some changes. See changes here:

https://reviews.freebsd.org/D12094
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2017-08-21 02:26:26 UTC 
Why did you remove JACK_DESC? You shouldn't try to reuse standard ones as much as possible, because in this case JACK has different meaning.
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2017-08-21 02:28:35 UTC 
(In reply to Yuri Victorovich from comment #6)

In this port, the meanings of options are subclasses of the standard ones:
{OPT}_DESC=	Build {OPT} sandbox
They are similar, but different.
Comment 8 Richard Gallamore freebsd_committer freebsd_triage 2017-08-21 03:01:32 UTC 
(In reply to Yuri Victorovich from comment #7)
They seem pretty similar to me, i'll readd it if you wish. Is that the only one you think should be readded?
Comment 9 Yuri Victorovich freebsd_committer freebsd_triage 2017-08-21 03:53:26 UTC 
(In reply to Richard Gallamore from comment #8)

Yes, please readd them.

Also, versions in the format g20170810 seem wrong. PKGNAMEPREFIX=g should be used, IMO.

Also, you should replace XORG with UI here:
> PLIST_SUB+=        XORG=
because it is for the case of UI, not XORG.

Otherwise, it looks good.

Thanks!
Comment 10 Richard Gallamore freebsd_committer freebsd_triage 2017-08-21 06:02:22 UTC 
(In reply to Yuri Victorovich from comment #9)
Readded options.

The g on DISTVERSION is how it should be according to PHB[1] example 5.13


[1] https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-description
Comment 11 Yuri Victorovich freebsd_committer freebsd_triage 2017-08-21 06:05:16 UTC 
(In reply to Richard Gallamore from comment #10)

> The g on DISTVERSION is how it should be according to PHB[1] example 5.13

Ok!
Comment 12 commit-hook freebsd_committer freebsd_triage 2017-08-21 07:03:23 UTC 
A commit references this bug:

Author: ultima
Date: Mon Aug 21 07:02:58 UTC 2017
New revision: 448453
URL: https://svnweb.freebsd.org/changeset/ports/448453

Log:
  Synthpod is an LV2 host. It can be run as a standalone app and be used as a
  tool for live performances or general audio and event filtering.

  It was conceptualized to fill the gap between pure textual (e.g. SuperCollider)
  and pure visual flow (e.g. Pure Data) audio programming paradigms.

  Potential fields of application may include:
  * Live audio synthesis
  * Real-time event scripting
  * Non-linear signal routing
  * Advanced control automation
  * Advanced event filtering
  * Live mixing
  * Live coding
  * Algorithmic composition
  * Interfacing to expressive controllers

  WWW: https://open-music-kontrollers.ch/lv2/synthpod

  PR:		221319
  Submitted by:	Yuri Victorovich (maintainer)
  Reviewed by:	matthew (mentor)
  Approved by:	matthew (mentor)
  Differential Revision:	https://reviews.freebsd.org/D12094

Changes:
  head/audio/Makefile
  head/audio/synthpod-lv2/
  head/audio/synthpod-lv2/Makefile
  head/audio/synthpod-lv2/distinfo
  head/audio/synthpod-lv2/files/
  head/audio/synthpod-lv2/files/patch-CMakeLists.txt
  head/audio/synthpod-lv2/pkg-descr
  head/audio/synthpod-lv2/pkg-message
  head/audio/synthpod-lv2/pkg-plist
Comment 13 Richard Gallamore freebsd_committer freebsd_triage 2017-08-21 07:08:11 UTC 
Committed, thanks!