Bug 221387 - [NEW PORT] audio/stk: Synthesis ToolKit in C++
Summary: [NEW PORT] audio/stk: Synthesis ToolKit in C++
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Richard Gallamore
URL:
Keywords:
Depends on:
Blocks: 221400
  Show dependency tree / graph
 
Reported: 2017-08-10 10:29 UTC by Yuri Victorovich
Modified: 2017-08-17 20:12 UTC (History)
1 user (show)

See Also:

Attachments
shar (7.74 KB, text/plain)
2017-08-10 10:29 UTC, Yuri Victorovich 		no flags Details
shar archive (8.29 KB, text/plain)
2017-08-11 05:59 UTC, Yuri Victorovich 		no flags Details
shar (8.29 KB, text/plain)
2017-08-16 22:00 UTC, Yuri Victorovich 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2017-08-10 10:29:44 UTC 
Created attachment 185228 [details]
shar
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2017-08-10 10:30:36 UTC 
QAs:
* pourdriere 11.1 amd64
* portlint
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2017-08-11 05:59:28 UTC 
Created attachment 185265 [details]
shar archive
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2017-08-16 22:00:35 UTC 
Created attachment 185501 [details]
shar

Improved patch and submitted it as an upstream PR.
Comment 4 Richard Gallamore freebsd_committer freebsd_triage 2017-08-17 07:52:11 UTC 
Looks good, couple things

* CONFIGURE_ARGS append flag is not needed.
* One of the patch files has dos endlines, this is not acceptable and can't be added to the ports tree as is. The USES dos2unix[1] must be used in this case.

Already fixed these entries if you would like to see the changes they are here[2].

[1] https://www.freebsd.org/doc/en/books/porters-handbook/slow-patch.html (near the bottom)
[2] https://reviews.freebsd.org/D12062
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2017-08-17 08:17:31 UTC 
Thanks!
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-08-17 19:43:07 UTC 
A commit references this bug:

Author: ultima
Date: Thu Aug 17 19:43:00 UTC 2017
New revision: 448181
URL: https://svnweb.freebsd.org/changeset/ports/448181

Log:
  The Synthesis ToolKit in C++ (STK) is a set of open source audio signal
  processing and algorithmic synthesis classes written in the C++ programming
  language.

  WWW: https://ccrma.stanford.edu/software/stk

  PR:		221387
  Submitted by:	Yuri Victorovich (maintainer)
  Reviewed by:	matthew (mentor)
  Approved by:	matthew (mentor)
  Differential Revision:	https://reviews.freebsd.org/D12062

Changes:
  head/audio/Makefile
  head/audio/stk/
  head/audio/stk/Makefile
  head/audio/stk/distinfo
  head/audio/stk/files/
  head/audio/stk/files/patch-configure.ac
  head/audio/stk/files/patch-src_RtAudio.cpp
  head/audio/stk/pkg-descr
  head/audio/stk/pkg-plist
Comment 7 Richard Gallamore freebsd_committer freebsd_triage 2017-08-17 19:45:40 UTC 
More one thing that Matthew mentioned about the patch-configure.ac.

It would be good to get these sort of changes upstreamed -- well, not exactly these changes, but something that will still work on other OSes but that avoids trying to configure linux specific sound systems on non-linux.

Thanks for your contributions, port has been committed, thanks!
Comment 8 Yuri Victorovich freebsd_committer freebsd_triage 2017-08-17 19:49:06 UTC 
I suggested the changes to upstream yesterday.
Comment 9 Richard Gallamore freebsd_committer freebsd_triage 2017-08-17 20:12:36 UTC 
(In reply to Yuri Victorovich from comment #8)
Awesome.