Bug 221490 - ports-mgmt/portlint: Produces bogus warning "use ${VARIABLE}, instead of $(VARIABLE)" for shell code
Summary: ports-mgmt/portlint: Produces bogus warning "use ${VARIABLE}, instead of $(VA...
Status: Closed DUPLICATE of bug 221397
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-13 21:07 UTC by Yuri Victorovich
Modified: 2017-08-14 17:32 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)

Attachments
Makefile (testcase) (1.10 KB, text/plain)
2017-08-13 21:07 UTC, Yuri Victorovich 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2017-08-13 21:07:58 UTC 
Created attachment 185371 [details]
Makefile (testcase)

> # portlint -A
> WARN: Makefile: [32]: use ${VARIABLE}, instead of $(VARIABLE).

- This code is for shell, so it is better to use the latter form. IMO, shell (with $$ prefix) variables should use round braces.
Please also fix the line number of such warnings, it's off by one.
Comment 1 Joe Marcus Clarke freebsd_committer freebsd_triage 2017-08-14 17:32:59 UTC 
This is a duplicate of 221397.

*** This bug has been marked as a duplicate of bug 221397 ***