Bug 221567 - [Port Update] irc/libircclient update from 1.7 to 1.9 & new port options
Summary: [Port Update] irc/libircclient update from 1.7 to 1.9 & new port options
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Julien Laffaye
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-16 19:32 UTC by loic.blot
Modified: 2018-01-23 22:58 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (jlaffaye)


Attachments
libircclient.patch (3.28 KB, patch)
2017-08-16 19:32 UTC, loic.blot
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description loic.blot 2017-08-16 19:32:15 UTC
Created attachment 185495 [details]
libircclient.patch

Hello,
the current libircclient is obsolète, it uses version 1.7, and it's in 1.9 since some time.

I updated it together with adding a SHARED option to port permitting to build the shared lib instead of static lib (i have some personnal projects which needs to use shared lib because they are libs themselves and some symbols are not found in static lib).

SHARED is off by default, but could be enabled if needed (default on many Linux distros)
Comment 1 Julien Laffaye freebsd_committer 2017-08-21 17:11:12 UTC
Hello, few notes:

- Your patch does not apply cleanly on Makefile
- You can use OPTIONS_SUB=	yes to manage the PLIST_SUB for you
- Why SHARED does no install the static version as well ?
- How do you manage ABI version changes ? Is it handled by upstream ?
Comment 2 loic.blot 2017-08-22 07:53:41 UTC
Hello Julien,
thanks for your reply

static version is only built when we don't set the SHARED flag, it's in the libircclient compilation recipe

There is no ABI version change between 1.7 and 1.9 it's just bugfixes (i ran libircclient on a C++ wrapper in 1.7 on FreeBSD and 1.9 on Archlinux since 2 years without problem)

I don't really understand how OPTIONS_SUB can help here, maybe you can help me with this
Comment 3 loic.blot 2018-01-23 22:58:47 UTC
@julien, i ping you to have an update on this port update