Created attachment 185550 [details] build fix - Fix build on 12-CURRENT by adding -Wno-expansion-to-defined to CFLAGS: In file included from src/core/application.cpp:28: In file included from src/core/tagreaderclient.h:25: In file included from ext/libclementine-tagreader/tagreadermessages.pb.h:9: In file included from /usr/local/include/google/protobuf/stubs/common.h:45: /usr/local/include/google/protobuf/stubs/port.h:263:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined] #if GOOGLE_PROTOBUF_USE_UNALIGNED ^ /usr/local/include/google/protobuf/stubs/port.h:259:40: note: expanded from macro 'GOOGLE_PROTOBUF_USE_UNALIGNED' # define GOOGLE_PROTOBUF_USE_UNALIGNED defined(_M_X64) || \ ^ /usr/local/include/google/protobuf/stubs/port.h:263:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined] /usr/local/include/google/protobuf/stubs/port.h:260:6: note: expanded from macro 'GOOGLE_PROTOBUF_USE_UNALIGNED' defined(__x86_64__) || defined(_M_IX86) || defined(__i386__) ^ /usr/local/include/google/protobuf/stubs/port.h:263:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined] /usr/local/include/google/protobuf/stubs/port.h:260:29: note: expanded from macro 'GOOGLE_PROTOBUF_USE_UNALIGNED' defined(__x86_64__) || defined(_M_IX86) || defined(__i386__) ^ /usr/local/include/google/protobuf/stubs/port.h:263:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined] /usr/local/include/google/protobuf/stubs/port.h:260:49: note: expanded from macro 'GOOGLE_PROTOBUF_USE_UNALIGNED' defined(__x86_64__) || defined(_M_IX86) || defined(__i386__) - Remove INSTALLS_ICONS, it's for GTK applications only - Add missing dependencies found by stage-qa
My build of clementine-player-1.3.1_12 is also failing on 11.1-RELEASE: In file included from src/covers/albumcoverloader.cpp:34: In file included from src/core/tagreaderclient.h:25: In file included from ext/libclementine-tagreader/tagreadermessages.pb.h:9: In file included from /usr/local/include/google/protobuf/stubs/common.h:45: /usr/local/include/google/protobuf/stubs/port.h:263:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined] #if GOOGLE_PROTOBUF_USE_UNALIGNED ^ /usr/local/include/google/protobuf/stubs/port.h:259:40: note: expanded from macro 'GOOGLE_PROTOBUF_USE_UNALIGNED' # define GOOGLE_PROTOBUF_USE_UNALIGNED defined(_M_X64) || \ ^ /usr/local/include/google/protobuf/stubs/port.h:263:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined] /usr/local/include/google/protobuf/stubs/port.h:260:6: note: expanded from macro 'GOOGLE_PROTOBUF_USE_UNALIGNED' defined(__x86_64__) || defined(_M_IX86) || defined(__i386__) ^ /usr/local/include/google/protobuf/stubs/port.h:263:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined] /usr/local/include/google/protobuf/stubs/port.h:260:29: note: expanded from macro 'GOOGLE_PROTOBUF_USE_UNALIGNED' defined(__x86_64__) || defined(_M_IX86) || defined(__i386__) ^ /usr/local/include/google/protobuf/stubs/port.h:263:5: error: macro expansion producing 'defined' has undefined behavior [-Werror,-Wexpansion-to-defined] /usr/local/include/google/protobuf/stubs/port.h:260:49: note: expanded from macro 'GOOGLE_PROTOBUF_USE_UNALIGNED' defined(__x86_64__) || defined(_M_IX86) || defined(__i386__) ^ 4 errors generated. ninja: build stopped: subcommand failed. *** Error code 1 Stop. make: stopped in /usr/ports/audio/clementine-player
r448493 | sunpoet | 2017-08-21 14:44:07 -0600 (Mon, 21 Aug 2017) | 5 lines Add upstream patch to fix warning with Clang 5+ Obtained from: https://github.com/google/protobuf/commit/5e39ecc569153db63bc4e1587f703c7894223375 Requested by: Kevin Bowling <kevin.bowling@kev009.com> This was fixed with a modification to the protobuf port.