Bug 221689 - sysutils/zfsnap2: must install periodic script in relevant directory instead of %%EXAMPLESDIR%%
Summary: sysutils/zfsnap2: must install periodic script in relevant directory instead ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Martin Matuska
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-21 11:27 UTC by Anton Saietskii
Modified: 2020-08-20 01:38 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (mm)

Attachments
Install the periodic scripts (5.86 KB, patch)
2020-07-28 03:02 UTC, Alan Somers 		dmgk: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Saietskii 2017-08-21 11:27:02 UTC 
According to pkg-plist, port installs periodic scripts to %%EXAMPLESDIR%%. So if one has OPTIONS_UNSET=EXAMPLES in make.conf, periodic won't be added at all.
Correct path is ${LOCALBASE}/etc/periodic/<...>
This works for previous version - sysutils/zfsnap.
Comment 1 Walter Schwarzenfeld freebsd_triage 2018-02-08 11:12:41 UTC 
Feedback please.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-10-23 00:19:40 UTC 
A commit references this bug:

Author: mm
Date: Tue Oct 23 00:18:53 UTC 2018
New revision: 482801
URL: https://svnweb.freebsd.org/changeset/ports/482801

Log:
  sysutils/zfsnap2: install periodic and completions to DATADIR

  PR:		221689
  Reported by:	Anton Saietskii <vsasjason@gmail.com>

Changes:
  head/sysutils/zfsnap2/Makefile
  head/sysutils/zfsnap2/pkg-plist
Comment 3 Alan Somers freebsd_committer freebsd_triage 2020-07-28 02:53:56 UTC 
Reopening because this change didn't actually fix the problem.  The scripts need to be installed to /usr/local/etc/periodic, not /usr/local/share/zfsnap2.
Comment 4 Alan Somers freebsd_committer freebsd_triage 2020-07-28 03:02:58 UTC 
Created attachment 216823 [details]
Install the periodic scripts

This patch installs the periodic scripts to the /usr/local/etc/periodic/{daily,weekly,monthly}.  It also combines the create and delete scripts into one, and fixes a bug in the delete script.  The latter changes have been submitted upstream.  However, upstream hasn't made a commit in 3 years, so don't hold your breath.

https://github.com/zfsnap/zfsnap/pull/112
Comment 5 Dmitri Goutnik freebsd_committer freebsd_triage 2020-08-20 01:29:38 UTC 
Comment on attachment 216823 [details]
Install the periodic scripts

Maintainer timeout (23 days)
Comment 6 commit-hook freebsd_committer freebsd_triage 2020-08-20 01:37:38 UTC 
A commit references this bug:

Author: asomers
Date: Thu Aug 20 01:37:06 UTC 2020
New revision: 545482
URL: https://svnweb.freebsd.org/changeset/ports/545482

Log:
  sysutils/zfsnap2: must install periodic script in relevant directory.

  Previously they were installed to %%EXAMPLESDIR%%.  This commit also
  combines the create and delete scripts into one, and fixes a bug in the
  delete script.

  Upstream PR:	https://github.com/zfsnap/zfsnap/pull/112

  PR:		221689
  Reported by:	Anton Saietskii <vsasjason@gmail.com>
  Approved by:	dmgk (ports) mm (maintainer timeout)
  Sponsored by:	Axcient

Changes:
  head/sysutils/zfsnap2/Makefile
  head/sysutils/zfsnap2/files/
  head/sysutils/zfsnap2/files/patch-periodic_xPERIODICx__zfsnap.sh
  head/sysutils/zfsnap2/pkg-plist