Bug 221721 - devel/libftdi1: build of 1.4 fails if 1.3 installed
Summary: devel/libftdi1: build of 1.4 fails if 1.3 installed
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Boris Samorodov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-22 17:21 UTC by John Hein
Modified: 2017-10-11 10:55 UTC (History)
1 user (show)

See Also:
bsam: maintainer-feedback+

Attachments
[patch] fix include dir search order for test/ (1013 bytes, patch)
2017-08-22 17:21 UTC, John Hein 		jcfyecrayz: maintainer-approval? (bsam)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2017-08-22 17:21:57 UTC 
Created attachment 185669 [details]
[patch] fix include dir search order for test/

The build of devel/libftdi1 PORTVERSION 1.4 fails if the old version (1.3) is installed...


==================================

/usr/bin/c++   -I/usr/local/include -Isrc -O2 -pipe -fstack-protector -fno-strict-aliasing -O2 -pipe -fstack-protector -fno-stri
ct-aliasing   -Wall -MD -MT test/CMakeFiles/test_libftdi1.dir/baudrate.cpp.o -MF test/CMakeFiles/test_libftdi1.dir/baudrate.cpp.
o.d -o test/CMakeFiles/test_libftdi1.dir/baudrate.cpp.o -c test/baudrate.cpp
test/baudrate.cpp:105:14: error: use of undeclared identifier 'TYPE_230X'; did you mean 'TYPE_232H'?
        case TYPE_230X:
             ^~~~~~~~~
             TYPE_232H
/usr/local/include/ftdi.h:25:97: note: 'TYPE_232H' declared here


==================================

The attached patch fixes the include ordering so it looks in the work directory for header files before looking at install headers (e.g., in /usr/local).
Comment 1 John Hein 2017-10-11 00:32:50 UTC 
ping
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-10-11 10:51:32 UTC 
A commit references this bug:

Author: bsam
Date: Wed Oct 11 10:50:37 UTC 2017
New revision: 451740
URL: https://svnweb.freebsd.org/changeset/ports/451740

Log:
  devel/libftdi1: Fix build if previous version is installed.

  PR:		221721
  Submitted by:	John Hein <z7dr6ut7gs@snkmail.com>

Changes:
  head/devel/libftdi1/files/patch-test_CMakeLists.txt
Comment 3 Boris Samorodov freebsd_committer freebsd_triage 2017-10-11 10:55:34 UTC 
Sorry for a delay. Committed, thanks!