Bug 221751 - [PATCH] devel/libgtop example depends on obsolete sbrk()
Summary: [PATCH] devel/libgtop example depends on obsolete sbrk()
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm64 Any
: --- Affects Some People
Assignee: freebsd-gnome (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-08-23 22:59 UTC by Brooks Davis
Modified: 2017-10-14 20:59 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (gnome)

Attachments
patch (1.16 KB, patch)
2017-08-24 18:47 UTC, Brooks Davis 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brooks Davis freebsd_committer freebsd_triage 2017-08-23 22:59:52 UTC 
libgtop is the top blocker on https://wiki.freebsd.org/PortsBrokenWithSbrk.  It's broken because an example uses some sbrk(0) calls as an unreliable and non-portable way to demonstrate memory utilization.  The attached patch removes them as they are pointless and likely wrong in practice.  This should allow libgtop to build and arm64 and riscv.
Comment 1 Brooks Davis freebsd_committer freebsd_triage 2017-08-24 18:47:13 UTC 
Created attachment 185725 [details]
patch
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-09-25 19:27:19 UTC 
A commit references this bug:

Author: kwm
Date: Mon Sep 25 19:27:05 UTC 2017
New revision: 450629
URL: https://svnweb.freebsd.org/changeset/ports/450629

Log:
  Allow to build on arm64 and riscv by removing the usage of sbrk(2), which
  doesn't exist on arm64 and riscv.

  PR:		221751
  Submitted by:	brooks@

Changes:
  head/devel/libgtop/files/patch-examples_mountlist.c