Bug 221816 - Cleanup duplicate code in USE_GITHUB
Summary: Cleanup duplicate code in USE_GITHUB
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Richard Gallamore
URL: https://reviews.freebsd.org/D12125
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2017-08-25 19:22 UTC by Richard Gallamore
Modified: 2017-09-04 18:37 UTC (History)
1 user (show)

See Also:
ultima: exp-run?

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Gallamore freebsd_committer freebsd_triage 2017-08-25 19:22:23 UTC 
This patch should have no functionality change on ports using USE_GITHUB. Due to the amount of ports it will affect however a exp-run will be required. The patch is located here[1].

[1] https://reviews.freebsd.org/D12125
Comment 1 Mathieu Arnold freebsd_committer freebsd_triage 2017-08-25 21:48:13 UTC 
Patch is not ready yet.
Comment 2 Richard Gallamore freebsd_committer freebsd_triage 2017-08-29 17:07:10 UTC 
Reopening, patch is now ready.
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2017-09-03 10:48:18 UTC 
Exp-run looks fine.
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-09-04 18:36:10 UTC 
A commit references this bug:

Author: ultima
Date: Mon Sep  4 18:35:50 UTC 2017
New revision: 449253
URL: https://svnweb.freebsd.org/changeset/ports/449253

Log:
  Cleanup duplicate code in USE_GITHUB

  PR:		221816
  Reviewed by:	lifanov (mentor), matthew (mentor), mat
  Approved by:	lifanov (mentor), matthew (mentor), mat
  Differential Revision:	https://reviews.freebsd.org/D12125

Changes:
  head/Mk/bsd.sites.mk