Created attachment 185766 [details] [PATCH] Makefile maintainer patch for clojure-mode.el Hi, I'd like to become the maintainer for the lang/Clojure-mode.el port.
(In reply to SPPH from comment #0) Sure, do you have a patch that brings the port to a newer version?
Created attachment 185822 [details] Patch moving clojure-mode.el-2.2.1 to clojure-mode.el-5.6.1 Please find attached patch file for moving from clojure-mode.el-2.2.1 to clojure-mode.el-5.6.1. Confirmed working amd64 FreeBSD version 11.1-release
Comment on attachment 185822 [details] Patch moving clojure-mode.el-2.2.1 to clojure-mode.el-5.6.1 I do not know what to do with this? I do mean a patch for actually updating the _port_ to 5.6.1.
Created attachment 185957 [details] Patch files for moving clojure-mode.el-2.2.1 to clojure-mode.el-5.6.1 Hi sorry for the confusion. I hope this helps: I've attached one file: There is actually only two files that need to be changed between the versions of clojure-mode-2.1.1 and clojure-mode-5.6.1, clojure-mode.el and the test.clj files; patch-clojure-mode.el.5.6.1.diff is the patch file for the entire project compared to the previous clojure-mode-2.2.1 file. I do apologize for any confusion, this is my first time patching something for the FreeBSD community; if this isn't right I'll just use the svn way.
(In reply to SPPH from comment #4) > I've attached one file: It's the same thing again. > There is actually only two files that need to be changed between the > versions of clojure-mode-2.1.1 and clojure-mode-5.6.1, > clojure-mode.el and the test.clj files; > patch-clojure-mode.el.5.6.1.diff is the patch file for the entire > project compared to the previous clojure-mode-2.2.1 file. Hmm, I think you have misunderstood me and are looking at this from the wrong level. Generally ports fetch source tarballs provided by upstream projects and do not include the entire upstream projects's changeset for going from version A to B. (The ports tree would be gigantic if we'd do this for all ports.) You can start by bumping PORTVERSION in the port's Makefile and go from there. I'd suggest studying the Porter's Handbook [1] a bit more however. If you need more help or guidance I'd suggest you open a thread on the FreeBSD Forums [2] or send an email to the ports@FreeBSD.org mailing list. [1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/index.html [2] https://forums.freebsd.org
Created attachment 185997 [details] updated Makefile which fetches latest version of Clojure-mode Updated the clojure-mode.el/ Makefile to fetch the latest clojure-mode from the github repository.
Created attachment 185998 [details] Updated pkg-plist to reflect new files included in newest versions of Clojure-mode Updated pkg-plist to reflect new files included in newest versions of Clojure-mode.
Created attachment 185999 [details] Updated distinfo of Clojure-mode Updated distinfo of Clojure-mode
A commit references this bug: Author: tobik Date: Sun Sep 3 11:11:58 UTC 2017 New revision: 449199 URL: https://svnweb.freebsd.org/changeset/ports/449199 Log: lang/clojure-mode.el: Update to 5.6.1 PR: 221818 Submitted by: harrigan-s@outlook.com (new maintainer) Changes: head/lang/clojure-mode.el/Makefile head/lang/clojure-mode.el/distinfo head/lang/clojure-mode.el/pkg-message head/lang/clojure-mode.el/pkg-plist
Committed with some changes. Thanks! +PORTREVISION= 5 When PORTVERSION is bumped, then PORTREVISION should be reset i.e. it needs to be removed. PORTREVISION is only bumped when we do packaging changes to the port (e.g. installing files in a different location, adding or removing dependencies, etc.) without moving to a newer version. For 2.1.1 we have done this 2 times (=> PORTREVISION=2) after the update to 2.1.1. +EXTRACT_SUFX= .tar.gz +GH_TAGNAME= ${PORTVERSION} These are set to the default values, so there is no reason to specify them in the port yourself. Generally it'd be easier for us if submit port changes as one patch instead of several individual patches.
MARKED AS SPAM