Bug 221852 - [patch] usb: Add UQ_MSC_NO_INQUIRY quirk for external "Intenso Memory" disk
Summary: [patch] usb: Add UQ_MSC_NO_INQUIRY quirk for external "Intenso Memory" disk
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: usb (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Ed Maste
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-08-27 10:10 UTC by Fabian Keil
Modified: 2017-11-08 08:06 UTC (History)
2 users (show)

See Also:
emaste: mfc-stable11+


Attachments
usb: Add UQ_MSC_NO_INQUIRY quirk for external "Intenso Memory" disk (4.71 KB, patch)
2017-08-27 10:10 UTC, Fabian Keil
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Keil 2017-08-27 10:10:37 UTC
Created attachment 185806 [details]
usb: Add UQ_MSC_NO_INQUIRY quirk for external "Intenso Memory" disk

The attached patch adds the UQ_MSC_NO_INQUIRY quirk for a certain external "Intenso Memory" disk.

Without the quirk the disk disappears shortly after beeing detected:

08:36:35 t520 kernel: ugen1.4: <Intenso External USB 3.0> at usbus1
08:36:36 t520 kernel: umass0 on uhub3
08:36:36 t520 kernel: umass0: <Intenso External USB 3.0, class 0/0, rev 2.10/3.07, addr 4> on usbus1
08:36:36 t520 kernel: umass0:  SCSI over Bulk-Only; quirks = 0x0100
08:36:36 t520 kernel: umass0:5:0: Attached to scbus5
08:36:36 t520 kernel: (probe0:umass-sim0:0:0:0): REPORT LUNS. CDB: a0 00 00 00 00 00 00 00 00 10 00 00
08:36:36 t520 kernel: (probe0:umass-sim0:0:0:0): CAM status: SCSI Status Error
08:36:36 t520 kernel: (probe0:umass-sim0:0:0:0): SCSI status: Check Condition
08:36:36 t520 kernel: (probe0:umass-sim0:0:0:0): SCSI sense: ILLEGAL REQUEST asc:20,0 (Invalid command operation code)
08:36:36 t520 kernel: (probe0:umass-sim0:0:0:0): Error 22, Unretryable error
08:37:49 t520 kernel: (probe0:umass-sim0:0:0:0): INQUIRY. CDB: 12 01 83 00 fc 00
08:37:49 t520 kernel: (probe0:umass-sim0:0:0:0): CAM status: CCB request completed with an error
08:37:49 t520 kernel: (probe0:umass-sim0:0:0:0): Retrying command
08:37:54 t520 kernel: (probe0:umass-sim0:0:0:0): INQUIRY. CDB: 12 01 83 00 fc 00
08:37:54 t520 kernel: (probe0:umass-sim0:0:0:0): CAM status: CCB request completed with an error
08:37:54 t520 kernel: (probe0:umass-sim0:0:0:0): Retrying command
08:38:00 t520 kernel: (probe0:umass-sim0:0:0:0): INQUIRY. CDB: 12 01 83 00 fc 00
08:38:00 t520 kernel: (probe0:umass-sim0:0:0:0): CAM status: CCB request completed with an error
08:38:00 t520 kernel: (probe0:umass-sim0:0:0:0): Retrying command
08:38:05 t520 kernel: (probe0:umass-sim0:0:0:0): INQUIRY. CDB: 12 01 83 00 fc 00
08:38:05 t520 kernel: (probe0:umass-sim0:0:0:0): CAM status: CCB request completed with an error
08:38:05 t520 kernel: (probe0:umass-sim0:0:0:0): Retrying command
08:38:11 t520 kernel: (probe0:umass-sim0:0:0:0): INQUIRY. CDB: 12 01 83 00 fc 00
08:38:11 t520 kernel: (probe0:umass-sim0:0:0:0): CAM status: CCB request completed with an error
08:38:11 t520 kernel: (probe0:umass-sim0:0:0:0): Error 5, Retries exhausted
08:38:44 t520 kernel: (da0:umass-sim0:0:0:0): got CAM status 0x44
08:38:44 t520 kernel: (da0:umass-sim0:0:0:0): fatal error, failed to attach to device
08:38:44 t520 kernel: g_access(918): provider da0 has error 6 set
08:38:44 t520 last message repeated 2 times

fk@t520 ~ $sudo usbconfig -u 1 -a 4 dump_device_desc
ugen1.4: <Intenso External USB 3.0> at usbus1, cfg=0 md=HOST spd=HIGH (480Mbps) pwr=ON (2mA)

  bLength = 0x0012
  bDescriptorType = 0x0001
  bcdUSB = 0x0210
  bDeviceClass = 0x0000  <Probed by interface class>
  bDeviceSubClass = 0x0000
  bDeviceProtocol = 0x0000
  bMaxPacketSize0 = 0x0040
  idVendor = 0x2109
  idProduct = 0x0701
  bcdDevice = 0x0307
  iManufacturer = 0x0001  <Intenso>
  iProduct = 0x0002  <External USB 3.0>
  iSerialNumber = 0x0003  <20130519000569>
  bNumConfigurations = 0x0001

Obtained from: ElectroBSD
Comment 1 Hans Petter Selasky freebsd_committer 2017-08-29 13:34:24 UTC
Patch looks good. --HPS
Comment 2 commit-hook freebsd_committer 2017-08-30 01:45:11 UTC
A commit references this bug:

Author: emaste
Date: Wed Aug 30 01:44:11 UTC 2017
New revision: 323011
URL: https://svnweb.freebsd.org/changeset/base/323011

Log:
  usb: Add external "Intenso Memory" disk UQ_MSC_NO_INQUIRY quirk

  PR:		221852
  Submitted by:	Fabian Keil
  Reviewed by:	hselasky
  Obtained from:	ElectroBSD
  MFC after:	1 week

Changes:
  head/sys/dev/usb/quirk/usb_quirk.c
  head/sys/dev/usb/usbdevs
Comment 3 commit-hook freebsd_committer 2017-09-06 02:07:10 UTC
A commit references this bug:

Author: emaste
Date: Wed Sep  6 02:06:51 UTC 2017
New revision: 323204
URL: https://svnweb.freebsd.org/changeset/base/323204

Log:
  MFC r323011: usb: Add external "Intenso Memory" disk quirk

  PR:		221852
  Submitted by:	Fabian Keil
  Obtained from:	ElectroBSD

Changes:
_U  stable/11/
  stable/11/sys/dev/usb/quirk/usb_quirk.c
  stable/11/sys/dev/usb/usbdevs