Bug 221854 - makefs: Reject UFS labels that are too long to fit
Summary: makefs: Reject UFS labels that are too long to fit
Status: In Progress
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: FreeBSD bugs mailing list
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-08-27 10:49 UTC by Fabian Keil
Modified: 2017-08-29 22:24 UTC (History)
1 user (show)

See Also:
fk: mfc-stable11?


Attachments
makefs: Reject UFS labels that are too long to fit (1006 bytes, patch)
2017-08-27 10:49 UTC, Fabian Keil
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Keil 2017-08-27 10:49:53 UTC
Created attachment 185810 [details]
makefs: Reject UFS labels that are too long to fit

If a specified UFS label is too long to fit, makefs currently silently truncates it.

This causes problems if the created file system contains files like
/etc/fstab that expect the whole label.

You may end up with a release image that was built "successfully"
but doesn't actually boot.

The attached patch lets makefs reject UFS labels that don't fit which
makes the issue easier to spot.

Obtained from: ElectroBSD