Created attachment 185859 [details] patch Update py-sphinx to 1.6.3.
Hi, there are hundreds ports that depends of textproc/py-sphinx, I would like to request an exp-run.
Exp-run results: http://package23.nyi.freebsd.org/build.html?mastername=110i386-default-PR221891&build=2017-08-29_08h54m02s Failure logs: http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-29_08h54m02s/logs/py27-pyaudio-0.2.11.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-29_08h54m02s/logs/py27-xapian-1.4.4.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-29_08h54m02s/logs/bpython-py27-0.17.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-29_08h54m02s/logs/cmake-3.8.2.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-29_08h54m02s/logs/llvm35-3.5.2_4.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-29_08h54m02s/logs/py27-Jinja2-doc-2.9.5.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-29_08h54m02s/logs/py27-noseofyeti-1.5.1.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-29_08h54m02s/logs/py27-pathlib-1.0.1.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-29_08h54m02s/logs/py27-pathtools-0.1.2_3.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-29_08h54m02s/logs/py27-pip-9.0.1.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-29_08h54m02s/logs/py27-virtualenv-15.1.0.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-29_08h54m02s/logs/py36-pip-9.0.1.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-29_08h54m02s/logs/py36-virtualenv-15.1.0.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-29_08h54m02s/logs/ghc-8.0.2_1.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-29_08h54m02s/logs/py27-gntp-0.8_3.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-29_08h54m02s/logs/xmlada-17.0.0.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-29_08h54m02s/logs/py27-cssselect-0.9.1_1.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-29_08h54m02s/logs/py27-webob-1.6.3.log More than 200 ports were skipped due to those failures
Thanks for the exp-run, I added a new port textproc/py-sphinxcontrib-websupport and also I modified py-sphinx Makefile adding new dependencies. Could you please run an exp-run again? Thanks.
Created attachment 185908 [details] New py-sphinx diff. This is the new diff, also the portstree need to be updated.
There is only one drawback with this update, as we can't add py3-* anymore, there are some py3 ports failing because I can't add an py3-sphinxcontrib-websupport. So, my suggestion is if py27 ports pass the build we might consider update it and after we move to PYTHON FLAVORS we fix any py3 failure related with this update.
Breaking ports isn't a good option. Either delay the update, or add the py3- port. Is 1.6.3 a delayable update, or does it contain fixes that we should have in the tree now?
(In reply to Adam Weinberger from comment #6) I'm more than happy to add the py3 port if possible and solve the py3 issues. This new version has features that we at iX needs to create documentation and manuals for TrueOS and FreeNAS. Also this port for months doesn't receive an update because it broken some other ports, I rather fix everything that comes up and update it. But of course it will requires a ping you guys to run exp-run.
Exp-run results: http://package23.nyi.freebsd.org/build.html?mastername=110i386-default-PR221891&build=2017-08-30_05h49m09s New failure logs: http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-30_05h49m09s/logs/owncloudclient-2.3.2.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-30_05h49m09s/logs/ahven-2.6_2.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-30_05h49m09s/logs/cmake-doc-3.8.2.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-30_05h49m09s/logs/gnatcoll-2016_1.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-30_05h49m09s/logs/kf5-extra-cmake-modules-5.37.0.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-30_05h49m09s/logs/llvm-devel-5.0.d20170524.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-30_05h49m09s/logs/llvm33-3.3_12.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-30_05h49m09s/logs/llvm34-3.4.2_6.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-30_05h49m09s/logs/llvm35-3.5.2_4.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-30_05h49m09s/logs/py27-pathtools-0.1.2_3.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-30_05h49m09s/logs/py27-spyder-2.3.7.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-30_05h49m09s/logs/py27-virtualenvwrapper-4.7.1.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-30_05h49m09s/logs/py36-pip-9.0.1.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-30_05h49m09s/logs/py36-virtualenv-15.1.0.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-30_05h49m09s/logs/shiboken-1.2.2_2.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-30_05h49m09s/logs/py27-scikit-image-0.13.0.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-30_05h49m09s/logs/py27-gntp-0.8_3.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-30_05h49m09s/logs/py27-cssselect-0.9.1_1.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-08-30_05h49m09s/logs/py27-kivy-1.9.1_4.log 3 ports were not tested due to those failures.
Created attachment 185967 [details] Unified diff. Hi, could you please run another round of exp-run?
Exp-run results: http://package23.nyi.freebsd.org/build.html?mastername=110i386-default-PR221891&build=2017-09-01_05h58m42s Failure logs: http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-09-01_05h58m42s/logs/owncloudclient-2.3.2_1.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-09-01_05h58m42s/logs/llvm-devel-5.0.d20170524.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-09-01_05h58m42s/logs/py27-spyder-2.3.7.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-09-01_05h58m42s/logs/py36-pip-9.0.1.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-09-01_05h58m42s/logs/py36-virtualenv-15.1.0.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-09-01_05h58m42s/logs/shiboken-1.2.2_3.log http://package23.nyi.freebsd.org/data/110i386-default-PR221891/2017-09-01_05h58m42s/logs/py27-pyquery-1.2.9.log 3 ports were not tested yet (amd64 only)
Created attachment 186058 [details] 09042017-Unifieddiff All ports fixed, only devel/llvm-devel seems to have no relation with this update. Also I need to add a textproc/py3-sphinxcontrib-websupport to be able to fix those py3-pip and py3-virtualenv issues. So in this case I will need portmgr approve. Please, could you run one more exp-run?
There is a problem: Duplicated origin for py27-sphinxcontrib-websupport-1.0.1: textproc/py-sphinxcontrib-websupport AND textproc/py3-sphinxcontrib-websupport.
(In reply to Antoine Brodin from comment #12) Adding a USES?=python to textproc/py-sphinxcontrib-websupport seems to fix this
Also there is a mismerge in your patch in devel/gnatcoll
The devel/llvm-devel changes break it on amd64, changes to this port can be omitted
Note: a cmake exp-run is ongoing so the plist will change
Can you refresh the patch: - after CMake updated to 3.9.2 - with textproc/py-sphinxcontrib-websupport USES fixed - with devel/gnatcoll mismerge removed - with devel/llvm-devel changes reverted
(In reply to Antoine Brodin from comment #17) Just a hands up! I just got back from a business trip, will get back to you tomorrow or after tomorrow.. Thanks!
Created attachment 186876 [details] New diff. Hi, Here is the new diff. I ran another round with poudriere for this port using python36 and python27, wall built ok. Please one more exp-run :) Thank you!
Created attachment 186877 [details] Unified 10032017 Sorry, use this diff, the previous one I forgot to add textproc/py3-sphinxcontrib-websupport. Best,
Both py-sphinx and py3-sphinx fail during patch phase.
Created attachment 187095 [details] 10122017 Remove py-sphinx files/patch-b03b7e543f5e135d046d2fe407def219336c12b2
I forgot to remove a patch from py-sphinx. I hope this time it goes good. Thanks again.
On 11.0 amd64, cmake-doc fails to package: http://package18.nyi.freebsd.org/data/110amd64-default-PR221891/2017-10-12_20h16m08s/logs/cmake-doc-3.9.3_1.log
Created attachment 187776 [details] Fixed cmake-doc Hi, here there is a new diff with the cmake-doc fixed. Thanks,
Please update your patch and mark the old ones obsolete.
(In reply to Antoine Brodin from comment #26) Hi, attached a new patch that cover the new python FLAVOR option. Best,
Created attachment 189425 [details] New py-sphinx diff 2018.
Comment on attachment 189425 [details] New py-sphinx diff 2018. py-sphinx fails to build: http://package22.nyi.freebsd.org/data/103amd64-default-PR221891/2018-01-05_19h24m16s/logs/errors/py36-sphinx-1.6.5,1.log http://package22.nyi.freebsd.org/data/103amd64-default-PR221891/2018-01-05_19h24m16s/logs/errors/py27-sphinx-1.6.5,1.log
Created attachment 189499 [details] 08012018 I forgot to remove py-sphinx patch. Sorry about that.
There is 1 new failure: x11-toolkits/py-kivy http://pb2.nyi.freebsd.org/data/103amd64-default-PR221891/2018-01-08_07h10m08s/logs/errors/py27-kivy-1.10.0.log
Created attachment 189607 [details] 11012018 Hi, With this patch, I have fixed the new issue on: x11-toolkits/py-kivy Thanks again for all tests.
Comment on attachment 189607 [details] 11012018 The patch fails to apply.
Created attachment 189618 [details] 11012018-2 Portstree updated and remade the patch.
On amd64, lang/swift fails to build: http://pb2.nyi.freebsd.org/data/111amd64-default-PR221891/2018-01-12_10h01m41s/logs/swift-3.1.1_3.log
*** Bug 225136 has been marked as a duplicate of this bug. ***
(In reply to Antoine Brodin from comment #35) It looks like a problem with lang/swift itself on amd64 and not directly related with py-sphinx. I don't know what to do with lang/swift. Any suggestion?
(In reply to Marcelo Araujo from comment #37) swift is ONLY_FOR_ARCHS: amd64
(In reply to Antoine Brodin from comment #38) Yes, I saw it! Any suggestion what I could do with swift? Perhaps I need to contact swills@ about this build issue as he is the maintainer? What do you think?
Yes, contact maintainer. You can also check upstream changes, like https://github.com/apple/swift/commit/9f0b2c7da4f0ba577aeee363e04fcb13084fa578 (I didn't try)
(In reply to Antoine Brodin from comment #40) With this patch, the build goes a bit further and fails with: Warning, treated as error: /wrkdirs/usr/ports/lang/swift/work/swift-3.1.1/swift/docs/proposals/InitializerInheritance.rst:395:Footnote [#] is not referenced.
(In reply to Antoine Brodin from comment #41) Maybe this patch fixes it: https://github.com/apple/swift/pull/9980/commits/9547aad68ca27885965101dbcd7816dbbf21f3c5
(In reply to Antoine Brodin from comment #42) Thank you! I will try it later.
Created attachment 189970 [details] patch for swift
OK, spent 2 days and definitely I would prefer mark lang/swift as broken. Even with that swift patch it still doesn't build clean on poudriere. Here are some PR for lang/swift: https://bugs.freebsd.org/bugzilla/buglist.cgi?component=Individual%20Port%28s%29&list_id=210507&product=Ports%20%26%20Packages&query_format=advanced&resolution=---&short_desc=lang%2Fswift&short_desc_type=allwordssubstr I got hit at least by 2 of them. Also I got hit by this one here: https://github.com/apple/swift/pull/14040 Can we mark it as broken and move forward? Best,
(In reply to Marcelo Araujo from comment #45) with the patch it built fine in poudriere on 11.1 amd64 for me.
(In reply to Antoine Brodin from comment #46) It doesn't for me! OK, shall I unify those 2 patches or are we good to go? I can make 2 commits, one for py-sphinx and another including your patch for lang/swift for all dependencies of py-sphinx. Best,
(In reply to Marcelo Araujo from comment #47) I prefer 1 atomic commit.
(In reply to Antoine Brodin from comment #48) OK, I'm gonna unify the path then! Thank you!
Created attachment 190077 [details] Unified patch Here we go, this is the unified patch that includes lang/swift changes. Changelog: - Update textproc/py-sphinx to 1.6.5. - Update all ports that depends of py-sphinx. Approved by: antoine (portmgr) Exprun by: antoine (several rounds)
Approved, don't commit the ".orig" files.
Please update Makefile before commit because some dependencies are incorrect. If you do not want to use the full version [1], please include the changes I mentioned in bug #225136, comment #2: - Remove BUILD_DEPENDS - Conditional RUN_DEPENDS (See [2]) - Add TEST_DEPENDS Thanks! [1] https://people.FreeBSD.org/~sunpoet/patch/textproc-py-sphinx.txt [2] https://github.com/sphinx-doc/sphinx/blob/master/setup.py#L38-L40
A commit references this bug: Author: araujo Date: Mon Jan 29 06:45:17 UTC 2018 New revision: 460241 URL: https://svnweb.freebsd.org/changeset/ports/460241 Log: - Update textproc/py-sphinx to 1.6.5. [0] - Update all ports that depends of py-sphinx. [0] - Add conditional RUN_DEPENDS. [1] - Add TEST_DEPENDS. [1] PR: ports/221891 [0] and ports/225136 [1] Submitted by: sunpoet [1] Approved by: antoine (portmgr) Exprun by: antoine (several rounds) Sponsored by: iXsystems, Inc. Changes: head/deskutils/owncloudclient/Makefile head/deskutils/owncloudclient/pkg-plist head/devel/ahven/Makefile head/devel/ahven/pkg-plist head/devel/cmake-doc/Makefile head/devel/cmake-doc/pkg-plist head/devel/kf5-extra-cmake-modules/Makefile head/devel/kf5-extra-cmake-modules/pkg-plist head/devel/llvm33/Makefile head/devel/llvm33/pkg-plist head/devel/llvm34/Makefile head/devel/llvm34/pkg-plist head/devel/llvm35/Makefile head/devel/llvm35/pkg-plist head/devel/py-pathtools/Makefile head/devel/py-pathtools/pkg-plist head/devel/py-spyder/Makefile head/devel/py-virtualenvwrapper/Makefile head/devel/py-virtualenvwrapper/pkg-plist head/devel/shiboken/Makefile head/devel/shiboken/pkg-plist head/lang/swift/Makefile head/lang/swift/files/patch-swift-docs-CMakeLists.txt head/lang/swift/files/patch-swift-docs-conf.py head/lang/swift/files/patch-swift-docs-proposals-InitializerInheritance.rst head/net/py-gntp/Makefile head/net/py-gntp/pkg-plist head/textproc/py-sphinx/Makefile head/textproc/py-sphinx/distinfo head/textproc/py-sphinx/files/patch-b03b7e543f5e135d046d2fe407def219336c12b2 head/textproc/py-sphinxcontrib-adadomain/Makefile head/www/py-cssselect/Makefile head/www/py-cssselect/pkg-plist head/www/py-pyquery/Makefile head/www/py-pyquery/pkg-plist head/x11-toolkits/py-kivy/Makefile head/x11-toolkits/py-kivy/pkg-plist
Thanks guys!
A commit references this bug: Author: sunpoet Date: Mon Jan 29 11:29:15 UTC 2018 New revision: 460284 URL: https://svnweb.freebsd.org/changeset/ports/460284 Log: Fix RUN_DEPENDS - Bump PORTREVISION for dependency change typing is a conditional RUN_DEPENDS for Python versions prior to 3.5. PR: 221891, 225136 Changes: head/textproc/py-sphinx/Makefile