Bug 221896 - [patch] adapt java/openjdk8 to new 'armv7' architecture
Summary: [patch] adapt java/openjdk8 to new 'armv7' architecture
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Mark Linimon
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-08-29 12:11 UTC by Mark Linimon
Modified: 2017-09-01 14:43 UTC (History)
1 user (show)

See Also:
jkim: maintainer-feedback+


Attachments
patch to java/openjdk8 (2.30 KB, patch)
2017-08-29 12:11 UTC, Mark Linimon
no flags Details | Diff
corrected patch to java/openjdk8 (2.30 KB, patch)
2017-08-29 21:12 UTC, Mark Linimon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Linimon freebsd_committer freebsd_triage 2017-08-29 12:11:26 UTC
Created attachment 185864 [details]
patch to java/openjdk8

The src tree is splitting 32-bit arm support into 'armv6' and the new 'armv7'.  This patch adds armv7 support.  It should provide no regression on any existing architecture.
Comment 1 Jung-uk Kim freebsd_committer 2017-08-29 16:46:58 UTC
"${ARCH:C/armv*/arm/}" is wrong.  It should be spelled "${ARCH:C/armv.*/arm/}", i.e., the pattern is a regular expression, not a glob pattern.
Comment 2 Jung-uk Kim freebsd_committer 2017-08-29 16:51:00 UTC
% cat armv7.mk 
JDK_JVMDIR=	lib/${ARCH:C/armv*/arm/:S/powerpc64/ppc64/}
% make -f armv7.mk -V JDK_JVMDIR ARCH=armv7
lib/arm7
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2017-08-29 20:22:35 UTC
Good catch.  I'll have an updated patch shortly.

Of course this seems to mean that :S and :M work differently.  Ew.
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2017-08-29 21:12:23 UTC
Created attachment 185893 [details]
corrected patch to java/openjdk8
Comment 5 Jung-uk Kim freebsd_committer 2017-08-29 21:24:04 UTC
(In reply to Mark Linimon from comment #4)
It looks good to me.  Ship it!
Comment 6 commit-hook freebsd_committer 2017-09-01 14:43:03 UTC
A commit references this bug:

Author: linimon
Date: Fri Sep  1 14:42:43 UTC 2017
New revision: 449081
URL: https://svnweb.freebsd.org/changeset/ports/449081

Log:
  The src tree is splitting 32-bit arm support into 'armv6' and the new
  'armv7'.  This patch adds armv7 support.  It should provide no regression
  on any existing architecture.

  PR:		221896
  Approved by:	maintainer

Changes:
  head/java/openjdk8/Makefile
Comment 7 Mark Linimon freebsd_committer freebsd_triage 2017-09-01 14:43:31 UTC
Committed, thanks.