Bug 221906 - sys/cddl: Allow to modify the ZFS deadman sysctls after the system is up
Summary: sys/cddl: Allow to modify the ZFS deadman sysctls after the system is up
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Allan Jude
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-08-29 12:58 UTC by Fabian Keil
Modified: 2019-06-08 16:03 UTC (History)
2 users (show)

See Also:
allanjude: mfc-stable12?
fk: mfc-stable11?


Attachments
sys/cddl: Allow to modify the ZFS deadman sysctls after the system is up (1.91 KB, patch)
2017-08-29 12:58 UTC, Fabian Keil
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Keil 2017-08-29 12:58:46 UTC
Created attachment 185875 [details]
sys/cddl: Allow to modify the ZFS deadman sysctls after the system is up

The attached patch changes the ZFS deadman sysctls from CTLFLAG_RDTUN
to CTLFLAG_RWTUN so they can be changed after the system is up.

There does not seem to be a technical reason why it shouldn't
be done and being able to temporarily disable the deadman
is useful when importing a pool that is backed by remote
storage (such as ggated running as onion service).

Obtained from: ElectroBSD
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-05-21 21:27:24 UTC
A commit references this bug:

Author: allanjude
Date: Tue May 21 21:26:18 UTC 2019
New revision: 348068
URL: https://svnweb.freebsd.org/changeset/base/348068

Log:
  ZFS: Make deadman tunables no longer read-only

  This allows the user to enable, disable, and adjust the I/O deadman at
  runtime. This can be especially useful when a pool is backed by remote
  storage (such as iscsi, ggated, etc).

  PR:		221906
  Submitted by:	Fabian Keil <fk@fabiankeil.de>
  Obtained from:	ElectroBSD
  MFC after:	1 week
  Sponsored by:	Klara Systems
  Event:		Waterloo Hackathon 2019

Changes:
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-06-05 20:28:12 UTC
A commit references this bug:

Author: allanjude
Date: Wed Jun  5 20:27:27 UTC 2019
New revision: 348702
URL: https://svnweb.freebsd.org/changeset/base/348702

Log:
  MFC r348068, r348071

  r348068:
  ZFS: Make deadman tunables no longer read-only

  This allows the user to enable, disable, and adjust the I/O deadman at
  runtime. This can be especially useful when a pool is backed by remote
  storage (such as iscsi, ggated, etc).

  PR:		221906
  Submitted by:	Fabian Keil <fk@fabiankeil.de>
  Obtained from:	ElectroBSD
  Sponsored by:	Klara Systems
  Event:		Waterloo Hackathon 2019

  r348071:
  Fix typo in r348068

  Sponsored by:	Klara Systems

Changes:
_U  stable/12/
  stable/12/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c