Bug 221916 - cease www/firefox-i18n dependency on old, incompatible xpi-quick-locale-switcher
Summary: cease www/firefox-i18n dependency on old, incompatible xpi-quick-locale-switcher
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-gecko (Nobody)
URL: http://www.freshports.org/www/firefox...
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2017-08-29 18:32 UTC by Graham Perrin
Modified: 2019-06-01 00:48 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gecko)


Attachments
Waterfox 56 locale selection UI (screenshot) (84.01 KB, image/png)
2017-11-29 14:03 UTC, Jan Beich
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Perrin freebsd_committer freebsd_triage 2017-08-29 18:32:28 UTC
Quick Locale Switcher 1.7.8.5 
<http://www.freshports.org/www/xpi-quick-locale-switcher/> 
apparently not updated since 2015-07-30 is 
not compatible with modern multiprocess Firefox, e10s. 

Working alternatives that are multiprocess-compatible include: 

Quick Locale Switcher 2
<https://addons.mozilla.org/firefox/addon/quick-locale-switcher-2/>, which presents itself in the Tools menu

> … isn't a WebExtensions addon, and I doubt it ever will be. … 

Simple Locale Switcher
<https://addons.mozilla.org/firefox/addon/simple-locale-switcher/>, which presents itself as a button in the toolbar (or overflow menu). At <http://forums.mozillazine.org/viewtopic.php?p=14759416#p14759416> on 2017-08-07 the developer wrote: 

> … As the availability of a WebExtensions API for it is still an 
> uncertain thing, I will try to keep the add-on working in 
> Nightly/Aurora while it's possible: I will update it soon.

----

Given the current choices of extensions, and the uncertainties around the transition to WebExtensions, I suggest simply: 

* ceasing the dependency on old, incompatible xpi-quick-locale-switcher
* adding a post-install message drawing attention to the choices.
Comment 1 Graham Perrin freebsd_committer freebsd_triage 2017-08-29 18:32:45 UTC
Quick Locale Switcher 1.7.8.5 
<http://www.freshports.org/www/xpi-quick-locale-switcher/> 
apparently not updated since 2015-07-30 is 
not compatible with modern multiprocess Firefox, e10s. 

Working alternatives that are multiprocess-compatible include: 

Quick Locale Switcher 2
<https://addons.mozilla.org/firefox/addon/quick-locale-switcher-2/>, which presents itself in the Tools menu

> … isn't a WebExtensions addon, and I doubt it ever will be. … 

Simple Locale Switcher
<https://addons.mozilla.org/firefox/addon/simple-locale-switcher/>, which presents itself as a button in the toolbar (or overflow menu). At <http://forums.mozillazine.org/viewtopic.php?p=14759416#p14759416> on 2017-08-07 the developer wrote: 

> … As the availability of a WebExtensions API for it is still an 
> uncertain thing, I will try to keep the add-on working in 
> Nightly/Aurora while it's possible: I will update it soon.

----

Given the current choices of extensions, and the uncertainties around the transition to WebExtensions, I suggest simply: 

* ceasing the dependency on old, incompatible xpi-quick-locale-switcher
* adding a post-install message drawing attention to the choices.
Comment 2 Thierry Thomas freebsd_committer freebsd_triage 2017-11-19 09:44:32 UTC
More generally, I have not yet found a way to install a WebExtension somewhere under $PREFIX, but only on a user basis. If we cannot do that, it means that we have to remove all xpi- ports.
Comment 3 Jan Beich freebsd_committer freebsd_triage 2017-11-19 10:24:44 UTC
(In reply to Thierry Thomas from comment #2)
> I have not yet found a way to install a WebExtension somewhere under $PREFIX, but only on a user basis

Not sure what you mean. Try

$ mkdir -p /usr/local/lib/firefox/browser/defaults/preferences
$ echo 'pref("extensions.autoDisableScopes", 11);' >/usr/local/lib/firefox/browser/defaults/preferences/xpi-ports.js

https://developer.mozilla.org/Add-ons/Installing_extensions#Disabling_install_locations

> If we cannot do that, it means that we have to remove all xpi- ports.

I don't care about xpi-* ports, plugins, etc. Mabye there're other gecko@ peers who do.

(In reply to Graham Perrin from comment #0)
> * adding a post-install message drawing attention to the choices.

Do you mean intl.locale.matchOS vs. general.useragent.locale? Firefox supports more locales than FreeBSD despite both using CLDR.

I guess, someone who uses the port needs to provide wording for pkg-message.
Comment 4 Jan Beich freebsd_committer freebsd_triage 2017-11-29 14:03:57 UTC
Created attachment 188394 [details]
Waterfox 56 locale selection UI (screenshot)

Waterfox has UI to select locale out of the box. 🤦

https://github.com/MrAlex94/Waterfox/commit/8a72a77d846c
Comment 5 Jan Beich freebsd_committer freebsd_triage 2017-12-07 14:23:33 UTC
Firefox 59 changed how locales are configured:
https://www.mail-archive.com/dev-platform@lists.mozilla.org/msg24441.html
Comment 6 Jan Beich freebsd_committer freebsd_triage 2019-01-30 03:47:54 UTC
Firefox 65 has language selection in Preferences (similar to Waterfox) while older releases can follow https://support.mozilla.org/kb/use-firefox-another-language which was translated into several languages.

I plan to remove all *-i18n under gecko@ to reduce maintenance.
Comment 7 commit-hook freebsd_committer freebsd_triage 2019-03-29 20:14:04 UTC
A commit references this bug:

Author: jbeich
Date: Fri Mar 29 20:13:46 UTC 2019
New revision: 497194
URL: https://svnweb.freebsd.org/changeset/ports/497194

Log:
  gecko: drop -i18n ports

  These haven't been QA'd for years, only blindly updated. After Firefox 57
  language selection via extension was broken but Firefox 65 gained native UI.

  PR:		221916

Changes:
  head/MOVED
  head/UPDATING
  head/mail/Makefile
  head/mail/thunderbird-i18n/
  head/www/Makefile
  head/www/firefox-esr-i18n/
  head/www/firefox-i18n/
  head/www/seamonkey-i18n/
Comment 8 Jan Beich freebsd_committer freebsd_triage 2019-03-29 20:33:00 UTC
-i18n aren't supported anymore. thunderbird and firefox-esr should have native UI around 2019-09-03 as well.
Comment 9 commit-hook freebsd_committer freebsd_triage 2019-06-01 00:46:42 UTC
A commit references this bug:

Author: jbeich
Date: Sat Jun  1 00:46:23 UTC 2019
New revision: 503205
URL: https://svnweb.freebsd.org/changeset/ports/503205

Log:
  www/firefox: unbreak language selection after r495403

  PR:		221916

Changes:
  head/www/firefox/Makefile
  head/www/firefox/files/patch-bug1554744
Comment 10 commit-hook freebsd_committer freebsd_triage 2019-06-01 00:48:45 UTC
A commit references this bug:

Author: jbeich
Date: Sat Jun  1 00:48:07 UTC 2019
New revision: 503210
URL: https://svnweb.freebsd.org/changeset/ports/503210

Log:
  MFH: r503205

  www/firefox: unbreak language selection after r495403

  PR:		221916
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2019Q2/
  branches/2019Q2/www/firefox/Makefile
  branches/2019Q2/www/firefox/files/patch-bug1554744