Bug 221982 - bsdinstall creates wpa_supplicant.conf with missing indentation
Summary: bsdinstall creates wpa_supplicant.conf with missing indentation
Status: In Progress
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Ed Maste
URL: https://reviews.freebsd.org/D13190
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-01 16:39 UTC by Ed Maste
Modified: 2017-12-07 03:57 UTC (History)
0 users

See Also:
emaste: mfc-stable11?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Maste freebsd_committer 2017-09-01 16:39:26 UTC
r309934 cleaned up some cases in bsdinstall to use heredocs but broke the indentation of the generated output - i.e. on a fresh install on a new laptop I ended up with:

netowrk={
ssid="myssid"
scan_ssid=0
psk="sharedkey"
priority=5
}

sh.1:
If the operator is “<<-” instead of “<<”, then leading tabs in the here-doc-text are stripped.
Comment 1 Devin Teske freebsd_committer 2017-09-06 23:13:41 UTC
Thanks for reporting this. I'll have a look ASAP
Comment 2 commit-hook freebsd_committer 2017-11-22 15:18:31 UTC
A commit references this bug:

Author: emaste
Date: Wed Nov 22 15:18:11 UTC 2017
New revision: 326094
URL: https://svnweb.freebsd.org/changeset/base/326094

Log:
  Fix indentation in bsdinstall-created wpa_supplicant.conf

  r309934 cleaned up some cases in bsdinstall to use heredocs but broke
  the indentation of the generated output, because <<- heredocs strip
  leading tabs.

  PR:		221982
  Reviewed by:	allanjude, dteske
  MFC after:	2 weeks
  Sponsored by:	The FreeBSD Foundation
  Differential Revision:	https://reviews.freebsd.org/D13190

Changes:
  head/usr.sbin/bsdinstall/scripts/wlanconfig
Comment 3 commit-hook freebsd_committer 2017-12-07 03:57:30 UTC
A commit references this bug:

Author: emaste
Date: Thu Dec  7 03:57:12 UTC 2017
New revision: 326653
URL: https://svnweb.freebsd.org/changeset/base/326653

Log:
  MFC r326094: Fix indentation in bsdinstall-created wpa_supplicant.conf

  r311690 (MFC of r309934) cleaned up some cases in bsdinstall to use
  heredocs but broke the indentation of the generated output, because <<-
  heredocs strip leading tabs.

  PR:		221982

Changes:
_U  stable/11/
  stable/11/usr.sbin/bsdinstall/scripts/wlanconfig