Bug 222026 - mail/geary: unbreak build with vala 0.36
Summary: mail/geary: unbreak build with vala 0.36
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-gnome mailing list
URL:
Keywords:
Depends on:
Blocks: 221941
  Show dependency treegraph
 
Reported: 2017-09-03 14:19 UTC by Carlos J. Puga Medina
Modified: 2017-10-14 12:28 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)


Attachments
patch (18.85 KB, patch)
2017-09-03 14:19 UTC, Carlos J. Puga Medina
no flags Details | Diff
patch (18.95 KB, patch)
2017-09-05 17:14 UTC, Carlos J. Puga Medina
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos J. Puga Medina freebsd_committer 2017-09-03 14:19:18 UTC
Created attachment 186031 [details]
patch

wrkdirs/usr/ports/mail/geary/work/geary-0.10.0/src/engine/imap/response/imap-fetch-data-decoder.vala:102.33-102.37: error: Argument 1: Cannot convert from `Gee.List<Geary.Imap.Flag>?' to `Gee.Collection<Geary.Imap.MessageFlag>'
        return new MessageFlags(flags);
                                ^^^^^
/wrkdirs/usr/ports/mail/geary/work/geary-0.10.0/src/engine/db/db-database.vala:258.35-258.80: error: Access to non-public constructor `Geary.Db.TransactionAsyncJob.new' denied
        TransactionAsyncJob job = new TransactionAsyncJob(type, cb, cancellable);
                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/wrkdirs/usr/ports/mail/geary/work/geary-0.10.0/src/engine/imap-db/imap-db-folder.vala:1963.22-1966.37: error: Access to non-public constructor `Geary.ImapDB.Attachment.new' denied
/wrkdirs/usr/ports/mail/geary/work/geary-0.10.0/src/engine/imap-db/imap-db-folder.vala:1583.59-1584.54: error: Assignment: Cannot convert from `Gee.HashMap<Geary.EmailIdentifier,Geary.EmailFlags>' to `Gee.Map<Geary.ImapDB.EmailIdentifier,Geary.EmailFlags>?'
/wrkdirs/usr/ports/mail/geary/work/geary-0.10.0/src/engine/imap-db/imap-db-folder.vala:1594.13-1594.15: error: The name `map' does not exist in the context of `Geary.ImapDB.Folder.do_get_email_flags'
            map.set(location.email_id,
            ^^^
/wrkdirs/usr/ports/mail/geary/work/geary-0.10.0/src/engine/imap-db/imap-db-folder.vala:1598.17-1598.19: error: The name `map' does not exist in the context of `Geary.ImapDB.Folder.do_get_email_flags'
        return (map.size > 0) ? map : null;
                ^^^
/wrkdirs/usr/ports/mail/geary/work/geary-0.10.0/src/engine/imap-db/imap-db-folder.vala:1598.33-1598.35: error: The name `map' does not exist in the context of `Geary.ImapDB.Folder.do_get_email_flags'
        return (map.size > 0) ? map : null;
                                ^^^
/wrkdirs/usr/ports/mail/geary/work/geary-0.10.0/src/engine/imap-db/imap-db-folder.vala:1598.33-1598.35: error: var declaration not allowed with non-typed initializer
        return (map.size > 0) ? map : null;
                                ^^^
/wrkdirs/usr/ports/mail/geary/work/geary-0.10.0/src/engine/imap-db/imap-db-folder.vala:1097.42-1097.90: error: Assignment: Cannot convert from `Gee.ArrayList<Geary.EmailIdentifier>' to `Gee.List<Geary.ImapDB.EmailIdentifier>?'
        Gee.List<ImapDB.EmailIdentifier> list = new Gee.ArrayList<Geary.EmailIdentifier>();
                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/wrkdirs/usr/ports/mail/geary/work/geary-0.10.0/src/engine/imap-db/imap-db-folder.vala:1100.13-1100.16: error: The name `list' does not exist in the context of `Geary.ImapDB.Folder.list_email_fields_by_id_async'
            list.add(iter.get());
            ^^^^
/wrkdirs/usr/ports/mail/geary/work/geary-0.10.0/src/engine/imap-db/imap-db-folder.vala:1101.17-1101.20: error: The name `list' does not exist in the context of `Geary.ImapDB.Folder.list_email_fields_by_id_async'
            if (list.size < LIST_EMAIL_FIELDS_CHUNK_COUNT && iter.has_next())
                ^^^^
/wrkdirs/usr/ports/mail/geary/work/geary-0.10.0/src/engine/imap-db/imap-db-folder.vala:1126.13-1126.16: error: The name `list' does not exist in the context of `Geary.ImapDB.Folder.list_email_fields_by_id_async'
            list.clear();
            ^^^^
/wrkdirs/usr/ports/mail/geary/work/geary-0.10.0/src/engine/imap-db/imap-db-folder.vala:1128.16-1128.19: error: The name `list' does not exist in the context of `Geary.ImapDB.Folder.list_email_fields_by_id_async'
        assert(list.size == 0);
               ^^^^
/wrkdirs/usr/ports/mail/geary/work/geary-0.10.0/src/engine/imap-db/imap-db-folder.vala:1130.9-1130.43: error: Return: Cannot convert from `Gee.HashMap<Geary.EmailIdentifier,Geary.Email.Field>?' to `Gee.Map<Geary.ImapDB.EmailIdentifier,Geary.Email.Field>?'
        return (map.size > 0) ? map : null;
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/wrkdirs/usr/ports/mail/geary/work/geary-0.10.0/src/engine/imap-engine/replay-ops/imap-engine-mark-email.vala:45.74-45.80: error: Argument 1: Cannot convert from `Gee.List<Geary.EmailIdentifier>' to `Gee.Collection<Geary.ImapDB.EmailIdentifier>'
        original_flags = yield engine.local_folder.get_email_flags_async(to_mark, cancellable);
                                                                         ^^^^^^^
/wrkdirs/usr/ports/mail/geary/work/geary-0.10.0/src/engine/imap-engine/imap-engine-generic-account.vala:742.70-742.85: error: Argument 1: Cannot convert from `Gee.Map<Geary.FolderPath,Geary.Folder>' to `Gee.Iterable<Gee.Map.Entry<Geary.FolderPath,Geary.Imap.Folder>>'
            = Geary.traverse<Gee.Map.Entry<FolderPath, Imap.Folder>>(existing_folders)
                                                                     ^^^^^^^^^^^^^^^^
/wrkdirs/usr/ports/mail/geary/work/geary-0.10.0/src/engine/imap-engine/imap-engine-generic-account.vala:769.39-769.86: error: Assignment: Cannot convert from `Gee.ArrayList<Geary.Folder>' to `Gee.Collection<Geary.ImapEngine.MinimalFolder>?'
        Gee.Collection<MinimalFolder> engine_added = new Gee.ArrayList<Geary.Folder>();
                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/wrkdirs/usr/ports/mail/geary/work/geary-0.10.0/src/engine/imap-engine/imap-engine-generic-account.vala:770.9-770.20: error: The name `engine_added' does not exist in the context of `Geary.ImapEngine.GenericAccount.update_folders_async'
        engine_added.add_all(build_folders(folders_to_build));
        ^^^^^^^^^^^^
/wrkdirs/usr/ports/mail/geary/work/geary-0.10.0/src/engine/imap-engine/imap-engine-generic-account.vala:792.13-792.24: error: The name `engine_added' does not exist in the context of `Geary.ImapEngine.GenericAccount.update_folders_async'
        if (engine_added.size > 0 || engine_removed.size > 0)
            ^^^^^^^^^^^^
/wrkdirs/usr/ports/mail/geary/work/geary-0.10.0/src/engine/imap-engine/imap-engine-generic-account.vala:793.55-793.66: error: The name `engine_added' does not exist in the context of `Geary.ImapEngine.GenericAccount.update_folders_async'
            notify_folders_added_removed(sort_by_path(engine_added), sort_by_path(engine_removed));
                                                      ^^^^^^^^^^^^
Compilation failed: 20 error(s), 0 warning(s)
ninja: build stopped: subcommand failed.
*** Error code 1

build log: http://package23.nyi.freebsd.org/data/110i386-default-PR221941/2017-08-31_07h56m24s/logs/geary-0.10.0.log
Comment 1 Carlos J. Puga Medina freebsd_committer 2017-09-05 17:14:08 UTC
Created attachment 186086 [details]
patch

Update patch to make it compatible with current vala 0.30 version.
Comment 2 Greg V 2017-10-04 22:52:36 UTC
This doesn't seem necessary with geary 0.12.0 (see bug 210718) and vala 0.38.1
Comment 3 Carlos J. Puga Medina freebsd_committer 2017-10-14 12:28:20 UTC
Superseded by bug 210718