iovctl prints contradicting help messages: root@thunderx:/zones # iovctl -C iovctl: Either the -d or -f flag must be specified iovctl: Usage: iovctl -C -f <config file> [-n] iovctl: iovctl -D [-d <PF device> | -f <config file>] [-n] iovctl: iovctl -S [-d <PF device> | -f <config file>] running it with -C says it needs the -d flag, then running it with -d says -C can't run with -d root@thunderx:/zones # iovctl -C -d /dev/iov/vnicpf0 iovctl: -d flag cannot be used with the -C flag iovctl: Usage: iovctl -C -f <config file> [-n] iovctl: iovctl -D [-d <PF device> | -f <config file>] [-n] iovctl: iovctl -S [-d <PF device> | -f <config file>]
Created attachment 186122 [details] a patch to fix the incorrect output This patch changes the output logic slightly and prints the correct message if iovctl -C is entered.
A commit references this bug: Author: rstone Date: Tue Sep 12 21:12:04 UTC 2017 New revision: 323506 URL: https://svnweb.freebsd.org/changeset/base/323506 Log: Fix incorrect error message in iovctl If the iovctl command was invoked with only the -C flag, the user would receive a message claiming that they needed to also supply either the -d flag or the -f flag. However, in the case of the -C mode, only the -f flag is acceptable. Correct this error message in this case. PR: 222050 Submitted by: Heinz N. Gies Reported by: Heinz N. Gies MFC after: 1 week Changes: head/usr.sbin/iovctl/iovctl.c
batch change of PRs untouched in 2018 marked "in progress" back to open.
Hi Ryan, do we need to do anything else to close this PR?