Bug 222064 - x11/rxvt-unicode: Support 256 Xresource colors and fixes for line/font spacing
Summary: x11/rxvt-unicode: Support 256 Xresource colors and fixes for line/font spacing
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thierry Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-05 10:09 UTC by Oleh Hushchenkov
Modified: 2017-09-16 10:22 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (thierry)

Attachments
Patch to support 256 Xresource colors and fixes for line/font spacing (20.69 KB, patch)
2017-09-05 10:09 UTC, Oleh Hushchenkov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleh Hushchenkov 2017-09-05 10:09:58 UTC 
Created attachment 186073 [details]
Patch to support 256 Xresource colors and fixes for line/font spacing

This fixes loading colors above 15th from .Xdefaults and spacing issues with some fonts.

Obtained from https://aur.archlinux.org/packages/rxvt-unicode-256xresources/
Comment 1 Thierry Thomas freebsd_committer freebsd_triage 2017-09-11 19:47:28 UTC 
I am sorry, but the proposed patch is considered incorrect, and has been rejected by upstream.

See also the previous PR 185656
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=185656
Comment 2 Oleh Hushchenkov 2017-09-12 04:43:37 UTC 
I see. But what about "Load colors above 15th from .Xdefaults" part of patch?
Comment 3 Thierry Thomas freebsd_committer freebsd_triage 2017-09-14 20:03:15 UTC 
(In reply to Oleh Hushchenkov from comment #2)

Could you please explain what problem it is supposed to solve?

This kind of message is often raised on the list about true colours, e.g.
http://lists.schmorp.de/pipermail/rxvt-unicode/2015q2/002108.html
but 256 colours is supposed to work.
Comment 4 Oleh Hushchenkov 2017-09-15 17:11:51 UTC 
Now I can customize colors with .Xdefauls like this:

*.foreground:	#c0c0c0
*.background:	#000000
*.cursorColor:	#e0e0e0

*.color0:	#000000
*.color1:	#b92222
*.color2:	#47aa06
*.color3:	#ce882f
*.color4:	#1f46a1
*.color5:	#85478f
*.color6:	#3e918b
*.color7:	#c0c0c0

*.color8:	#505050
*.color9:	#e93232
*.color10:	#72ea26
*.color11:	#eeb32f
*.color12:	#4f71e9
*.color13:	#b557bf
*.color14:	#3ec1bb
*.color15:	#f6f6f6

But colors from 16 to 255 can't be setup like this. With this part of patch I can do this.
Comment 5 Thierry Thomas freebsd_committer freebsd_triage 2017-09-16 10:22:41 UTC 
(In reply to Oleh Hushchenkov from comment #4)

OK, but this is not a problem with the FreeBSD port, and it would be better to submit this patch upstream.