Bug 222114 - Corsair K68 requires a USB quirk added
Summary: Corsair K68 requires a USB quirk added
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: usb (show other bugs)
Version: 11.1-STABLE
Hardware: Any Any
: --- Affects Some People
Assignee: Oleksandr Tymoshenko
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2017-09-07 02:11 UTC by Zane C. Bowers-Hadley
Modified: 2019-04-25 00:58 UTC (History)
1 user (show)

See Also:
gonzo: mfc-stable11+
koobs: mfc-stable12+


Attachments
patch against head (1.12 KB, patch)
2017-12-17 08:29 UTC, Zane C. Bowers-Hadley
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zane C. Bowers-Hadley 2017-09-07 02:11:45 UTC
Just grabbed a Corsair K68 keyboard and began having issues with strange it acting like either escape or control was constantly held down.

The quirk UQ_KBD_BOOTPROTO is required to fix it.



Bus /dev/usb Device /dev/ugen0.10: ID 1b1c:1b3f Corsair 



ugen0.10: <Corsair Corsair Gaming K68 Keyboard> at usbus0
ukbd2 on uhub3
ukbd2: <Corsair Corsair Gaming K68 Keyboard, class 0/0, rev 2.00/1.00, addr 16> on usbus0
kbd4 at ukbd2
ukbd3 on uhub3
ukbd3: <Corsair Corsair Gaming K68 Keyboard, class 0/0, rev 2.00/1.00, addr 16> on usbus0
kbd5 at ukbd3
uhid1 on uhub3
uhid1: <Corsair Corsair Gaming K68 Keyboard, class 0/0, rev 2.00/1.00, addr 16> on usbus0
device_attach: uhid1 attach returned 12
Comment 1 Hans Petter Selasky freebsd_committer 2017-09-07 07:38:26 UTC
This should be communicated back to Corsair.

Please make a patch for sys/dev/usb/quick/usb_quirk.c and sys/dev/usb/usbdevs .

--HPS
Comment 2 Zane C. Bowers-Hadley 2017-12-17 08:29:27 UTC
Created attachment 188909 [details]
patch against head
Comment 3 Zane C. Bowers-Hadley 2017-12-17 08:32:02 UTC
Howdy!

I would like to offer my sincere apologies about taking so long to get back with the patch for this.

Any suggestion about how to go abuot poking Corsair?
Comment 4 Hans Petter Selasky freebsd_committer 2017-12-17 09:33:44 UTC
Maybe you could simply ask them to test their keyboards with FreeBSD referring this PR?

--HPS
Comment 5 commit-hook freebsd_committer 2019-01-28 20:23:05 UTC
A commit references this bug:

Author: gonzo
Date: Mon Jan 28 20:22:18 UTC 2019
New revision: 343533
URL: https://svnweb.freebsd.org/changeset/base/343533

Log:
  [usb] Add UQ_KBD_BOOTPROTO quirk for Corsair K68 keyboard

  PR:		222114
  Submitted by:	Zane C. Bowers-Hadley <vvelox@vvelox.net>
  MFC after:	1 week

Changes:
  head/sys/dev/usb/quirk/usb_quirk.c
  head/sys/dev/usb/usbdevs
Comment 6 commit-hook freebsd_committer 2019-02-04 10:20:00 UTC
A commit references this bug:

Author: gonzo
Date: Mon Feb  4 10:19:27 UTC 2019
New revision: 343737
URL: https://svnweb.freebsd.org/changeset/base/343737

Log:
  MFC r343224, r343533

  r343224:
  Add KBD_BOOTPROTO quirk for Logitech G510s USB keyboard

  PR:		232136
  Submitted by:	dgilbert@eicat.ca

  r343533:
  [usb] Add UQ_KBD_BOOTPROTO quirk for Corsair K68 keyboard

  PR:		222114
  Submitted by:	Zane C. Bowers-Hadley <vvelox@vvelox.net>

Changes:
_U  stable/12/
  stable/12/sys/dev/usb/quirk/usb_quirk.c
  stable/12/sys/dev/usb/usbdevs
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2019-03-25 13:38:35 UTC
Assign to committer resolving (base r343533, base r343737)

Any reason not to merge this to stable/11?
Comment 8 Oleksandr Tymoshenko freebsd_committer freebsd_triage 2019-03-26 18:07:16 UTC
(In reply to Kubilay Kocak from comment #7)

No reason, I'll take care of this.
Comment 9 commit-hook freebsd_committer 2019-04-25 00:56:23 UTC
A commit references this bug:

Author: gonzo
Date: Thu Apr 25 00:56:12 UTC 2019
New revision: 346655
URL: https://svnweb.freebsd.org/changeset/base/346655

Log:
  MFC r343224, r343533

  r343224:
  Add KBD_BOOTPROTO quirk for Logitech G510s USB keyboard

  PR:		232136
  Submitted by:	dgilbert@eicat.ca

  r343533:
  [usb] Add UQ_KBD_BOOTPROTO quirk for Corsair K68 keyboard

  PR:		222114
  Submitted by:	Zane C. Bowers-Hadley <vvelox@vvelox.net>

Changes:
_U  stable/11/
  stable/11/sys/dev/usb/quirk/usb_quirk.c
  stable/11/sys/dev/usb/usbdevs