Bug 222163 - 'make makepatch' does not explicitly extract the source tarball.
Summary: 'make makepatch' does not explicitly extract the source tarball.
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-09 06:33 UTC by Ed Schouten
Modified: 2017-09-09 18:46 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Schouten freebsd_committer 2017-09-09 06:33:46 UTC
Quick bug report before I'm on vacation, to make sure this won't get lost...

This morning I was slightly amazed that 'make makepatch' threw away all of my patches for a port. It turns out that if you run 'make clean' and thus no longer have a build directory for a port, it does nothing more than throwing away all of your patches.

I suspect that the 'makepatch' target should depend on 'patch', somewhere in Mk/.
Comment 1 Antoine Brodin freebsd_committer 2017-09-09 06:44:07 UTC
Depending on patch is wrong since patch does a lot (shebanfix and post-patch for instance)
Comment 2 Mathieu Arnold freebsd_committer 2017-09-09 08:27:57 UTC
There is no possible "good" way to have makepatch depend on anything.

While it needs to happen after do-patch, and for example, dos2unix, the post-patch and shebangfix should not run.
Comment 3 Ed Schouten freebsd_committer 2017-09-09 18:13:54 UTC
If depending on some target is out of the question, maybe we should simply patch up 'makepatch' to explicitly bail out when WRKDIR does not exist?
Comment 4 Adam Weinberger freebsd_committer 2017-09-09 18:46:17 UTC
The bail condition should probably be a lack of *.orig.