Quick bug report before I'm on vacation, to make sure this won't get lost...
This morning I was slightly amazed that 'make makepatch' threw away all of my patches for a port. It turns out that if you run 'make clean' and thus no longer have a build directory for a port, it does nothing more than throwing away all of your patches.
I suspect that the 'makepatch' target should depend on 'patch', somewhere in Mk/.
Depending on patch is wrong since patch does a lot (shebanfix and post-patch for instance)
There is no possible "good" way to have makepatch depend on anything.
While it needs to happen after do-patch, and for example, dos2unix, the post-patch and shebangfix should not run.
If depending on some target is out of the question, maybe we should simply patch up 'makepatch' to explicitly bail out when WRKDIR does not exist?
The bail condition should probably be a lack of *.orig.
I was unable to reproduce this with
make clean && make makepatch
on a port with patches in files/
Can we close this now?