Bug 222277 - Don't (try to) build qlnx if the user objects to binary blobs
Summary: Don't (try to) build qlnx if the user objects to binary blobs
Status: In Progress
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Many People
Assignee: Ed Maste
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2017-09-13 05:52 UTC by Fabian Keil
Modified: 2017-09-13 13:29 UTC (History)
1 user (show)

See Also:
fk: mfc-stable10?
fk: mfc-stable11?


Attachments
Don't (try to) build qlnx if the user objects to binary blobs (853 bytes, patch)
2017-09-13 05:52 UTC, Fabian Keil
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Keil 2017-09-13 05:52:34 UTC
Created attachment 186319 [details]
Don't (try to) build qlnx if the user objects to binary blobs

As previously reported in:
https://lists.freebsd.org/pipermail/svn-src-all/2017-April/143083.html
the qlnx module contains source-less microcode but is built and
installed even if WITHOUT_SOURCELESS_UCODE is set.

The attached patch fixes this.

Obtained from: ElectroBSD
Comment 1 commit-hook freebsd_committer 2017-09-13 12:17:07 UTC
A commit references this bug:

Author: emaste
Date: Wed Sep 13 12:16:27 UTC 2017
New revision: 323539
URL: https://svnweb.freebsd.org/changeset/base/323539

Log:
  qlnx: exclude if WITHOUT_SOURCELESS_UCODE set

  PR:		222277
  Submitted by:	Fabian Keil
  Obtained from:	ElectroBSD
  MFC after:	1 week

Changes:
  head/sys/modules/Makefile