Bug 222289 - lang/cjs: remove CONFLICTS_BUILD=spidermonkey17-1.7
Summary: lang/cjs: remove CONFLICTS_BUILD=spidermonkey17-1.7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-13 14:57 UTC by John Hein
Modified: 2020-10-27 08:14 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)


Attachments
svn-diff-cjs (449 bytes, patch)
2019-08-07 23:06 UTC, Walter Schwarzenfeld
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2017-09-13 14:57:46 UTC
I think that 'CONFLICTS_BUILD=spidermonkey17-1.7' should be removed.  I don't think it is correct.  If I remove that CONFLICTS_BUILD line, install spidermonkey17 and build (and install) cjs, the build does not fail.  And I don't detect any problem with either installed port.

Note that the CONFLICTS_BUILD line has been there from the beginning, so the commit log offers no hints about why it was added.
Comment 1 Walter Schwarzenfeld freebsd_triage 2019-08-07 23:06:41 UTC
Created attachment 206347 [details]
svn-diff-cjs
Comment 2 Walter Schwarzenfeld freebsd_triage 2019-08-07 23:07:52 UTC
Reset Maintainer. Two years without reaction.
Comment 3 commit-hook freebsd_committer 2020-10-27 08:11:43 UTC
A commit references this bug:

Author: danfe
Date: Tue Oct 27 08:11:24 UTC 2020
New revision: 553424
URL: https://svnweb.freebsd.org/changeset/ports/553424

Log:
  GC outdated conflicts: lang/njs was removed on 2011-06-09 and
  CONFLICTS_BUILD=spidermonkey17 does not reflect reality these
  days, if it ever did.

  PR:	222289

Changes:
  head/lang/cjs/Makefile
  head/lang/spidermonkey17/Makefile
  head/lang/spidermonkey185/Makefile
  head/lang/spidermonkey24/Makefile
Comment 4 Alexey Dokuchaev freebsd_committer 2020-10-27 08:14:31 UTC
I also couldn't see how it's useful and GC'ed it as part of ports r553424.