Bug 222332 - mail/neomutt: consider KYOTOCABINET instead of TOKYOCABINET as default
Summary: mail/neomutt: consider KYOTOCABINET instead of TOKYOCABINET as default
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Baptiste Daroussin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-14 16:29 UTC by Alexandre C. Guimarães
Modified: 2018-08-28 00:02 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (bapt)

Attachments
Updating mail/neomutt port. (3.44 KB, patch)
2017-09-14 18:58 UTC, Alexandre C. Guimarães 		no flags Details | Diff
Setting KYOTOCABINET as default header-cache instead of TOKYOKABINET (846 bytes, patch)
2017-09-14 19:19 UTC, Alexandre C. Guimarães 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre C. Guimarães freebsd_committer freebsd_triage 2017-09-14 16:29:45 UTC 
Hello.

mail/neomutt do have lmdb and tokyocabinet header-cache options ON by default.

Please, consider kyotokabinet to be default instead of tokyocabinet, since even tokyocabinet dev recommends to use kyotocabinet instead:

http://fallabs.com/tokyocabinet/

I can bring a patch.

Thanks!
Comment 1 Larry Rosenman freebsd_committer freebsd_triage 2017-09-14 17:57:49 UTC 
Please attach a patch. Thanks!
Comment 2 Alexandre C. Guimarães freebsd_committer freebsd_triage 2017-09-14 18:58:07 UTC 
Created attachment 186386 [details]
Updating mail/neomutt port.

* Updating to 20170912
* Setting KYOTOCABINET as default header-cache instead of TOKYOCABINET
* Fix minor warning about USE_GITHUB appearing before USE in the port.
Comment 3 Larry Rosenman freebsd_committer freebsd_triage 2017-09-14 19:02:04 UTC 
I'd already updated the HEAD port with 20170912 and the portlint warning.
Comment 4 Alexandre C. Guimarães freebsd_committer freebsd_triage 2017-09-14 19:19:14 UTC 
Created attachment 186389 [details]
Setting KYOTOCABINET as default header-cache instead of TOKYOKABINET

* Setting KYOTOCABINET as default header-cache instead of TOKYOKABINET
Comment 5 Alexandre C. Guimarães freebsd_committer freebsd_triage 2017-09-14 19:19:57 UTC 
I forgot to update the ports tree.

Sorry about that.
Thanks!
Comment 6 Baptiste Daroussin freebsd_committer freebsd_triage 2017-09-15 05:32:34 UTC 
I was reluctant into doing that. Because of kyotocabinet being GPLv3 (note the missing L even if there is an explicit link exception).

The goal in the default set of options on is to have the fastest database for header cache: lmdb and another one which is safe over NFS (lmdb is not safe over NFS) and tokyocabinet was chosen because among the safe database format it is the faster which a license allowing linking by default without being controversial.

Is there any end user visible improvements to add kyotocabinet? It is a "big" new dependency:
Flat size      : 13.1MiB
Pkg size       : 1.37MiB
Comment 7 Alexandre C. Guimarães freebsd_committer freebsd_triage 2017-09-15 05:53:49 UTC 
I do understand your concern, I had not paid attention to the kyotocabinet license.

About the end user improvements, I was not using tokyocabinet before and currently  I do not have a high amount of e-mails to say anything about that with some "authority".

So, I totally agree with you.

Thanks!
Comment 8 Walter Schwarzenfeld freebsd_triage 2018-02-12 19:03:25 UTC 
=> So, I totally agree with you.

means that we can close here?