Bug 222337 - www/nginx: some style fix; Makefile cleanup
Summary: www/nginx: some style fix; Makefile cleanup
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-14 19:53 UTC by m1cro
Modified: 2017-11-03 17:07 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (joneum)


Attachments
nginx-cleanup (11.13 KB, patch)
2017-09-14 19:53 UTC, m1cro
rum1cro: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description m1cro 2017-09-14 19:53:43 UTC
Created attachment 186390 [details]
nginx-cleanup

- !empty(PORT_OPTIONS:MOPTION) changed by ${PORT_OPTIONS:MOPTION}. I think it looks better
- http_accesskey was removed in r439844, cleanup it.

portlint: 16 warns (were 18, related with http_accesskey)
testport: OK (12.0-CURRENT #0 r322368, default options)
Comment 1 commit-hook freebsd_committer 2017-11-03 17:05:40 UTC
A commit references this bug:

Author: joneum
Date: Fri Nov  3 17:04:43 UTC 2017
New revision: 453414
URL: https://svnweb.freebsd.org/changeset/ports/453414

Log:
  Do the port clean-up:

   -replace '!empty(PORT_OPTIONS:M...)' with '${PORT_OPTIONS:M...}';
   -http_accesskey was removed in r439844, cleanup it.

  PR:		222337
  Reported by:	m1cro <rum1cro@yandex.ru>
  Approved by:	tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D12915

Changes:
  head/www/nginx/Makefile
Comment 2 Jochen Neumeister freebsd_committer 2017-11-03 17:07:40 UTC
Landed. Thanks. :-)