Bug 222344 - security/libargon2: Add pkgconfig file
Summary: security/libargon2: Add pkgconfig file
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2017-09-15 01:26 UTC by Christopher Hall
Modified: 2021-02-15 15:13 UTC (History)
1 user (show)

See Also:


Attachments
patch argon2 to install a pkgconfig data file (1.60 KB, patch)
2017-09-15 01:26 UTC, Christopher Hall
dbaio: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Hall 2017-09-15 01:26:58 UTC
Created attachment 186401 [details]
patch argon2 to install a pkgconfig data file

This change just add the pkgconfig file to the installed files to make using the library more convenient.
Comment 1 Danilo G. Baio freebsd_committer freebsd_triage 2017-09-17 12:53:27 UTC
Thank you for your contribution. Could you please:

Confirm that this change passes QA (portlint, poudriere in particular). 
For more information, see: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing.html

Set the maintainer-approval flag value to + on attachments for ports you are maintainer of. 
Attachment -> Details -> maintainer-approval [+]
Comment 2 Christopher Hall 2017-09-18 04:48:50 UTC
During a port test I see this message which relates to the sed command which modifies the pkgconfig file.


===> Validating port with portlint
WARN: Makefile: possible use of absolute pathname "/usr@${PREFIX}@g;".
0 fatal errors and 1 warning found.


Otherwise the port test is successful.
 
libargon2 is building successfully on Poudriere; with 11.0 and 10.3 setups.
Comment 3 Christopher Hall 2017-12-11 02:15:55 UTC
since this has not been committed and there are other problems with this port I will revise the patch
Comment 4 Christopher Hall 2017-12-11 02:23:40 UTC
I will put the entire patch in bug #224190 so this bug can just be closed without being committed
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-12-12 11:39:27 UTC
A commit references this bug:

Author: tz
Date: Tue Dec 12 11:38:49 UTC 2017
New revision: 456119
URL: https://svnweb.freebsd.org/changeset/ports/456119

Log:
  security/libargon2: Add SONAME to shared library

  Also add pkg-config file

  PR:           224190 222344
  Submitted by: Christopher Hall (maintainer)
  Reported by:  xxjack12xx@gmail.com
  Approved by:  maintainer

Changes:
  head/security/libargon2/Makefile
  head/security/libargon2/pkg-plist
Comment 6 commit-hook freebsd_committer freebsd_triage 2021-02-15 15:13:42 UTC
A commit references this bug:

Author: pkubaj
Date: Mon Feb 15 15:13:36 UTC 2021
New revision: 565315
URL: https://svnweb.freebsd.org/changeset/ports/565315

Log:
  databases/mongodb44: add LTO option and make it the default

  PR:		222344
  Approved by:	ronald-lists@klop.ws (maintainer)

Changes:
  head/databases/mongodb44/Makefile