Bug 222380 - devel/llvm*: Build and install pp-trace executable when building llvm with extras selected
Summary: devel/llvm*: Build and install pp-trace executable when building llvm with ex...
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Brooks Davis
URL:
Keywords: easy, feature, needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2017-09-17 05:17 UTC by bye
Modified: 2017-10-12 18:24 UTC (History)
1 user (show)

See Also:
koobs: maintainer-feedback? (brooks)


Attachments
devel-llvm40-makefile-diff (282 bytes, patch)
2017-09-17 05:17 UTC, bye
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description bye 2017-09-17 05:17:40 UTC
Created attachment 186445 [details]
devel-llvm40-makefile-diff

/devel/llvm40 has a some extra tools; pp-trace is one of them. 

There's a Makefile diff attached. Making that change then the pp-trace executable will be built, then it should be easy to put it in the proper place with the install command.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2017-09-17 05:24:12 UTC
Assign to maintainer.

Patch should include changes for all devel/llvm* ports.
Comment 2 Brooks Davis freebsd_committer 2017-09-19 15:08:01 UTC
This works, but will cause a ton of rebuilding globally if I commit.  Are there other tools you'd like to add to the set?
Comment 3 commit-hook freebsd_committer 2017-09-19 23:45:26 UTC
A commit references this bug:

Author: brooks
Date: Tue Sep 19 23:44:36 UTC 2017
New revision: 450176
URL: https://svnweb.freebsd.org/changeset/ports/450176

Log:
  Disable LLDB builds on 10.x as they don't link.

  Attempt to correct default targets. [0]

  Fix more references to clang-format50 and use a more future proof
  patching approach. [1]

  Build and install pp-trace with the EXTRAS target.

  PR:		219779 [0], 220995 [1], 222380 [2]

Changes:
  head/devel/llvm50/Makefile
  head/devel/llvm50/files/clang-patch-tools_clang_tools_clang-format_clang-format-sublime.py
  head/devel/llvm50/files/clang-patch-tools_clang_tools_clang-format_clang-format.py
  head/devel/llvm50/files/clang-patch-tools_clang_tools_clang-format_git-clang-format
  head/devel/llvm50/pkg-plist
Comment 4 commit-hook freebsd_committer 2017-09-20 01:34:00 UTC
A commit references this bug:

Author: brooks
Date: Wed Sep 20 01:33:42 UTC 2017
New revision: 450183
URL: https://svnweb.freebsd.org/changeset/ports/450183

Log:
  Don't install a wrapper for the not installed pp-trace program.

  GC an obsolete patch.

  PR:		222380

Changes:
  head/devel/llvm50/Makefile
  head/devel/llvm50/files/clang-patch-svn-r280672
  head/devel/llvm50/pkg-plist
Comment 5 Brooks Davis freebsd_committer 2017-09-20 01:34:55 UTC
I've reverted the previous change.  The patch installs a wrapper for pp-trace which is not built so the wrapper is useless.
Comment 6 Brooks Davis freebsd_committer 2017-10-12 18:24:23 UTC
I'd be happy to accept a patch that actually builds and installs pp-trace, but this didn't do it and I'm insufficiently motivated to figure out the cmake bits to do it my self.