Bug 222397 - security/apache-xml-security-c: Fails to build with C++11
Summary: security/apache-xml-security-c: Fails to build with C++11
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Palle Girgensohn
URL: https://issues.apache.org/jira/browse...
Keywords:
Depends on:
Blocks: 221890
  Show dependency treegraph
 
Reported: 2017-09-17 12:39 UTC by Roger Leigh
Modified: 2018-02-09 12:02 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (girgen)


Attachments
Correct invalid implicit type conversions (5.15 KB, patch)
2017-09-17 12:39 UTC, Roger Leigh
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Leigh 2017-09-17 12:39:10 UTC
Created attachment 186463 [details]
Correct invalid implicit type conversions

Upstream ticket https://issues.apache.org/jira/browse/SANTUARIO-471 (merged)

Attached patch to correct C++11 build failure.
Comment 1 Roger Leigh 2018-02-08 19:50:51 UTC
Anything blocking applying this patch, or anything more I can do to help?
Comment 2 Palle Girgensohn freebsd_committer freebsd_triage 2018-02-08 20:31:29 UTC
How do I test building with c++11?
Comment 3 Roger Leigh 2018-02-08 20:57:45 UTC
Set this in security/apache-xml-security-c/Makefile:

USES=          compiler:c++11-lang gmake libtool tar:bzip2 ssl
USE_CXXSTD=    c++11

It's not provided in this current patch because switching to the C++11 ABI would require all reverse dependencies to be rebuilt; I was going to propose a switchover once the C++11 support was present in all packages blocking #221890

https://github.com/rleigh-codelibre/freebsd-ports/commit/71eb1781a917f552ed1a1e5a06a3d2f9041a908a
Comment 4 Palle Girgensohn freebsd_committer freebsd_triage 2018-02-08 21:06:35 UTC
I can't make it fail. There was s patch to fix some clang problems, perhaps that fixed enough  for c++11?

revision r459469 ?
Comment 5 Roger Leigh 2018-02-08 22:52:37 UTC
I don't see how that revision could affect outright illegal type conversions in C++11 code.  Last time I tested, this was strictly required.  Was the compiler definitely passing -std=c++11 when you tested?

I'll retry with the current ports anyway to confirm.
Comment 6 Roger Leigh 2018-02-09 12:02:03 UTC
I've tested with C++11 and C++14 and the current port is now building OK, thanks.  This bug can be closed.