Bug 222434 - lang/phantomjs: fails to set C++11 or later as required by ICU >= 59 on FreeBSD 10.3
Summary: lang/phantomjs: fails to set C++11 or later as required by ICU >= 59 on FreeB...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: needs-patch
Depends on:
Blocks: 222433
  Show dependency treegraph
 
Reported: 2017-09-18 22:11 UTC by Jan Beich
Modified: 2018-02-09 09:20 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2017-09-18 22:11:20 UTC
Running configuration tests...
The ICU library support cannot be enabled.
 Turn on verbose messaging (-v) to /wrkdirs/usr/ports/lang/phantomjs/work/phantomjs-2.1.1/src/qt/qtbase/configure to see the final report.
 If you believe this message is in error you may use the continue
 switch (-continue) to /wrkdirs/usr/ports/lang/phantomjs/work/phantomjs-2.1.1/src/qt/qtbase/configure to continue.

ERROR: Failed to build PhantomJS! Configuration of Qt Base failed.

http://sprunge.us/CRST
Comment 1 Jan Beich freebsd_committer 2017-09-18 22:24:57 UTC
FreeBSD 11.0 is unaffected. On FreeBSD 10.3 libc++ doesn't define char16_t via <__config> which breaks configure check:

$ clang++ $(icu-config --cppflags --ldflags) src/qt/qtbase/config.tests/unix/icu/icu.cpp
In file included from src/qt/qtbase/config.tests/unix/icu/icu.cpp:34:
In file included from /usr/local/include/unicode/utypes.h:38:
/usr/local/include/unicode/umachine.h:347:13: error: unknown type name 'char16_t'
    typedef char16_t UChar;
            ^
1 error generated.
Comment 2 Jan Beich freebsd_committer 2017-09-18 22:50:49 UTC
<__config> is bootlegged via <stddef.h> is due to https://llvm.org/viewvc/llvm-project?view=revision&revision=249761
Comment 3 commit-hook freebsd_committer 2018-02-09 09:13:51 UTC
A commit references this bug:

Author: jbeich
Date: Fri Feb  9 09:12:50 UTC 2018
New revision: 461290
URL: https://svnweb.freebsd.org/changeset/ports/461290

Log:
  devel/icu: drop C++98 compatibility workarounds

  Now that both USE_GCC and -CURRENT default to C++14 there's little
  reason to complicate maintenance. Revert r449685 to usher consumers
  into post-C++11 world.

  PR:		222433 222434 222435

Changes:
  head/databases/evolution-data-server/Makefile
  head/devel/icu/Makefile
  head/devel/icu/files/patch-common_unicode_platform.h
  head/devel/icu/files/patch-common_unicode_umachine.h
  head/devel/icu/files/patch-common_unicode_unistr.h
  head/devel/icu/files/patch-revert-r40077
  head/devel/icu-le-hb/Makefile
  head/devel/pecl-intl/Makefile
  head/devel/php70-intl/Makefile
  head/devel/php71-intl/Makefile
  head/devel/php72-intl/Makefile
  head/games/openttd/Makefile
  head/lang/phantomjs/files/patch-src_qt_qtbase_config.tests_unix_icu_icu.pro
  head/lang/v8-devel/Makefile
  head/misc/sword/Makefile
  head/print/tex-xetex/Makefile
  head/print/texlive-base/Makefile
  head/sysutils/gdisk/Makefile
  head/www/cppcms/Makefile