Created attachment 186547 [details] patch file * Update license information. * Regerate patches to fix portlint warning.
I don't mind clarifying, which of the BSD-licenses this is -- though I do not understand the significance of it for anyone. Even if LICENSE_FILE needs to defined, it should be further cleaned up -- removing the C++ comments and other references to the original file. I'm against to modifying the patches -- the change adds no value. Appeasing portlint is not, by itself, a sufficiently good reason...
(In reply to Mikhail T. from comment #1) In bug #222458 maintainer of devel/py-pylru-cache told me following example in Porter's Handbook. https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/licenses.html#licenses-license-ex1 And source archives of this port doesn't any license file. So LICENSE_FILE need not to be set in this case and I will update patch about it. As for updating patches, Porter's Handbook requires checking ports with portlint. Reference: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing-portlint.html And when checking this port with 'portlint -C' it results as following. yasu@rolling-vm-freebsd1[1506]% pwd /net/freebsd/ports/ports.original/graphics/libjxr yasu@rolling-vm-freebsd1[1507]% portlint -C /net/freebsd/ports/ports.original/graphics/libjxr WARN: Makefile: "BROKEN_mips" has to appear earlier. WARN: /am/eastasia/usr0/freebsd/ports/ports.original/graphics/libjxr/files/patch-bug748590: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. WARN: /am/eastasia/usr0/freebsd/ports/ports.original/graphics/libjxr/files/patch-typos: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. WARN: Consider to set DEVELOPER=yes in /etc/make.conf 0 fatal errors and 4 warnings found. yasu@rolling-vm-freebsd1[1508]% So updating patches is required to fix portlint warnings.
(In reply to Yasuhiro KIMURA from comment #2) > Porter's Handbook requires checking ports with portlint. True. > So updating patches is required to fix portlint warnings. Not true -- there is no requirement, that portlint be fully satisfied.
Created attachment 186638 [details] updated patch file (In reply to Mikhail T. from comment #3) OK, OK, I have understood enough that you never want to change these patch files whatever reason there is. I updated patch so it only fixes license information. So please approve it.
(In reply to Yasuhiro KIMURA from comment #4) > I updated patch so it only fixes license information. So please approve it. Yes, please, go ahead and commit. Thank you!
Committed, thanks!
A commit references this bug: Author: swills Date: Fri Oct 20 15:17:09 UTC 2017 New revision: 452534 URL: https://svnweb.freebsd.org/changeset/ports/452534 Log: graphics/libjxr: Update license information [1] While here, fix portlint warning PR: 222459 [1] Submitted by: Yasuhiro KIMURA <yasu@utahime.org> [1] Approved by: Mikhail T. <mi@ALDAN.algebra.com> (maintainer) [1] Changes: head/graphics/libjxr/Makefile head/graphics/libjxr/files/patch-bug748590 head/graphics/libjxr/files/patch-image_decode_JXRTranscode.c head/graphics/libjxr/files/patch-jxrencoderdecoder_JxrEncApp.c head/graphics/libjxr/files/patch-jxrgluelib_JXRMeta.h head/graphics/libjxr/files/patch-typos
(In reply to commit-hook from comment #7) > head/graphics/libjxr/files/patch-bug748590 > head/graphics/libjxr/files/patch-image_decode_JXRTranscode.c > head/graphics/libjxr/files/patch-jxrencoderdecoder_JxrEncApp.c > head/graphics/libjxr/files/patch-jxrgluelib_JXRMeta.h > head/graphics/libjxr/files/patch-typos I never approved any changes to the patches. Indeed, I explicitly disapproved of them -- right here on this ticket! > While here, fix portlint warning Please, do not do this again.