Bug 222564 - misc/rump: fails to build with lang/gcc7 or later
Summary: misc/rump: fails to build with lang/gcc7 or later
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Vanilla I. Shu
URL:
Keywords: needs-patch
Depends on:
Blocks: 222542
  Show dependency tree / graph
 
Reported: 2017-09-24 17:32 UTC by Jan Beich
Modified: 2017-10-06 06:29 UTC (History)
2 users (show)

See Also:
jbeich: maintainer-feedback? (vanilla)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2017-09-24 17:32:07 UTC 
$ echo "DEFAULT_VERSIONS += gcc=7" >>${__MAKE_CONF:-/etc/make.conf}
$ make
[...]
ndpool.c: In function 'rndpool_add_data':
src/lib/librump/../../sys/rump/../kern/kern_rndpool.c:184:8: error: this statement may fall through [-Werror=implicit-fallthrough=]
    val = *buf++;
    ~~~~^~~~~~~~
src/lib/librump/../../sys/rump/../kern/kern_rndpool.c:185:3: note: here
   case 2:
   ^~~~
src/lib/librump/../../sys/rump/../kern/kern_rndpool.c:186:8: error: this statement may fall through [-Werror=implicit-fallthrough=]
    val = val << 8 | *buf++;
    ~~~~^~~~~~~~~~~~~~~~~~~
src/lib/librump/../../sys/rump/../kern/kern_rndpool.c:187:3: note: here
   case 1:
   ^~~~
cc1: all warnings being treated as errors

build log: http://sprunge.us/UZHA
Comment 1 Vanilla I. Shu freebsd_committer freebsd_triage 2017-10-06 06:29:00 UTC 
I add some patches to fix building with clang,

so do not require gcc anymore.