Bug 222697 - sysutils/devcpu-data: allow custom cpucontrol(8) flags
Summary: sysutils/devcpu-data: allow custom cpucontrol(8) flags
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: easy, needs-qa, patch
Depends on:
Blocks:
 
Reported: 2017-09-30 10:28 UTC by Konstantin Belousov
Modified: 2017-10-16 17:23 UTC (History)
2 users (show)

See Also:
riggs: maintainer-feedback+


Attachments
Add rc.conf variable microcode_update_flags to allow user to specify additional flags (1.25 KB, patch)
2017-09-30 10:28 UTC, Konstantin Belousov
no flags Details | Diff
Add rc.conf variable microcode_update_flags to allow user to specify additional flags (1.38 KB, patch)
2017-09-30 16:18 UTC, Konstantin Belousov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Belousov freebsd_committer 2017-09-30 10:28:52 UTC
Created attachment 186811 [details]
Add rc.conf variable microcode_update_flags to allow user to specify additional flags

This is mostly to allow to specify '-n'.  Ideally the flag would be added unconditionally, but it cannot until all supported FreeBSD base versions get it added.  So for now user is allowed to do this manually.
Comment 1 Konstantin Belousov freebsd_committer 2017-09-30 16:18:17 UTC
Created attachment 186815 [details]
Add rc.conf variable microcode_update_flags to allow user to specify additional flags

Fix a bug where empty flags variable caused issues (remove "" around the variable expansion).
Comment 2 Thomas Zander freebsd_committer 2017-10-16 16:37:38 UTC
Maintainer timeout
Comment 3 commit-hook freebsd_committer 2017-10-16 16:38:07 UTC
A commit references this bug:

Author: riggs
Date: Mon Oct 16 16:37:56 UTC 2017
New revision: 452203
URL: https://svnweb.freebsd.org/changeset/ports/452203

Log:
  Allow custom cpucontrol(8) flags

  PR:		222697
  Submitted by:	kib
  Approved by:	maintainer timeout

Changes:
  head/sysutils/devcpu-data/Makefile
  head/sysutils/devcpu-data/files/microcode_update.in