Bug 222885 - [maintainer-update] www/gitea: fix version number in built binary
Summary: [maintainer-update] www/gitea: fix version number in built binary
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: easy, needs-qa, patch
Depends on:
Blocks:
 
Reported: 2017-10-09 21:50 UTC by Stefan Bethke
Modified: 2017-10-16 15:18 UTC (History)
1 user (show)

See Also:
riggs: merge-quarterly-

Attachments
patch to fix the version number (873 bytes, text/plain)
2017-10-09 21:50 UTC, Stefan Bethke 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Bethke 2017-10-09 21:50:40 UTC 
Created attachment 187033 [details]
patch to fix the version number

Gitea releases don't supply the release version number; the automatic method to obtain the version number in the Gitea build system only works when sources are checked out from git.

See https://github.com/go-gitea/gitea/issues/1136#issuecomment-311622745
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-10-14 09:29:44 UTC 
A commit references this bug:

Author: riggs
Date: Sat Oct 14 09:28:41 UTC 2017
New revision: 452050
URL: https://svnweb.freebsd.org/changeset/ports/452050

Log:
  Fix version number in resulting binary

  Details:
  Gitea releases don't supply the release version number;
  the automatic method to obtain the version number in
  the Gitea build system only works when sources are checked
  out from git.

  PR:		222885
  Submitted by:	stb@lassitu.de (maintainer)
  MFH:		2017Q4

Changes:
  head/www/gitea/Makefile
Comment 2 Stefan Bethke 2017-10-14 11:42:53 UTC 
A merge to quarterly is probably not warranted, as this change is purely cosmetic.

I've also just submitted the update to 1.2.0, FWIW. #223001
Comment 3 Thomas Zander freebsd_committer freebsd_triage 2017-10-16 15:18:51 UTC 
MFH not needed according to maintainer