Bug 222900 - ports-mgmt/synth: Enable watchdog monitor by default
Summary: ports-mgmt/synth: Enable watchdog monitor by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-10 13:49 UTC by Eric Turgeon
Modified: 2017-10-10 14:25 UTC (History)
2 users (show)

See Also:
ericturgeon.bsd: maintainer-feedback+
tobik: merge-quarterly+

Attachments
diff patch for synth port (527 bytes, text/plain)
2017-10-10 13:49 UTC, Eric Turgeon 		no flags Details
synth.diff (753 bytes, patch)
2017-10-10 14:05 UTC, Tobias Kortkamp 		ericturgeon.bsd: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Turgeon 2017-10-10 13:49:29 UTC 
Created attachment 187049 [details]
diff patch for synth port

Hi, I have made an update to the synth port due to a problem reported from a user that without WATCHDOG synth will hang on the ports that stop building and we also that problem with building pkg for GhostBSD.

https://github.com/jrmarino/synth/issues/53#issuecomment-335425660

I have disabled NOWATCHDOG by default if a user wants to have NOWATCHDOG they should be enabled it. Since WATCHDOG is a default feature of synth and prevents synth to hang it should be on by default.

The diff file is attached.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2017-10-10 14:05:14 UTC 
(In reply to ericturgeon.bsd from comment #0)
Not a big fan of the double negative NOWATCHDOG option.  Can I rename it to just WATCHDOG please?

+PORTEPOCH=	1

Bump PORTREVISION.  PORTEPOCH should only be bumped when the new version number is less than the old version number.  This isn't the case here.
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2017-10-10 14:05:56 UTC 
Created attachment 187050 [details]
synth.diff
Comment 3 Eric Turgeon 2017-10-10 14:14:22 UTC 
Comment on attachment 187050 [details]
synth.diff

Patch look fine
Comment 4 Eric Turgeon 2017-10-10 14:19:43 UTC 
Tobias Kortkamp yeah great idea!

I meant to use PORTREVISION instead of PORTEPOCH.

Thanks
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-10-10 14:20:19 UTC 
A commit references this bug:

Author: tobik
Date: Tue Oct 10 14:19:33 UTC 2017
New revision: 451704
URL: https://svnweb.freebsd.org/changeset/ports/451704

Log:
  ports-mgmt/synth: Build with watchdog monitor by default

  Without WATCHDOG Synth will hang on the ports that stop building [1].

  While here:
  - Rename the double negative NOWATCHDOG option to WATCHDOG

  [1] https://github.com/jrmarino/synth/issues/53#issuecomment-335425660

  PR:		222900
  Submitted by:	ericturgeon.bsd@gmail.com (maintainer)
  MFH:		2017Q4

Changes:
  head/ports-mgmt/synth/Makefile
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-10-10 14:24:24 UTC 
A commit references this bug:

Author: tobik
Date: Tue Oct 10 14:23:34 UTC 2017
New revision: 451705
URL: https://svnweb.freebsd.org/changeset/ports/451705

Log:
  MFH: r451704

  ports-mgmt/synth: Build with watchdog monitor by default

  Without WATCHDOG Synth will hang on the ports that stop building [1].

  While here:
  - Rename the double negative NOWATCHDOG option to WATCHDOG

  [1] https://github.com/jrmarino/synth/issues/53#issuecomment-335425660

  PR:		222900
  Submitted by:	ericturgeon.bsd@gmail.com (maintainer)

  Approved by:	ports-secteam blanket

Changes:
_U  branches/2017Q4/
  branches/2017Q4/ports-mgmt/synth/Makefile
Comment 7 Tobias Kortkamp freebsd_committer freebsd_triage 2017-10-10 14:25:21 UTC 
Committed. Thanks!