Bug 222909 - misc/xfce4-weather-plugin: Fix search forecast location
Summary: misc/xfce4-weather-plugin: Fix search forecast location
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-xfce (Nobody)
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2017-10-10 19:07 UTC by Olivier Duchateau
Modified: 2017-10-23 13:25 UTC (History)
2 users (show)

See Also:
madpilot: maintainer-feedback+
madpilot: merge-quarterly+

Attachments
Fix search location in propriety window (1.90 KB, patch)
2017-10-10 19:07 UTC, Olivier Duchateau 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau 2017-10-10 19:07:08 UTC 
Created attachment 187055 [details]
Fix search location in propriety window

- Add patch, which fixes search location in propriety dialog (a user-agent must be defined otherwise search is not working)
- Bump PORTREVISION

While I'm here, make portlint happy

This update is needed in 2017Q4.

Note: An update is planned soon (perhaps this week or next week).
Comment 1 Olivier Duchateau 2017-10-10 19:08:35 UTC 
Add Guido (madpilot@)
Comment 2 Olivier Duchateau 2017-10-10 19:09:52 UTC 
Currently misc/xfce4-weather-plugin is broken without this patch.
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-10-11 07:21:53 UTC 
A commit references this bug:

Author: madpilot
Date: Wed Oct 11 07:21:43 UTC 2017
New revision: 451735
URL: https://svnweb.freebsd.org/changeset/ports/451735

Log:
  Import xfce4-weather-plugin upstream patch required to make location
  search work after external site added additional requirement.

  PR:		222909
  Submitted by:	Olivier Duchateau <duchateau.olivier@gmail.com>
  Obtained from:	https://git.xfce.org/panel-plugins/xfce4-weather-plugin/commit/?id=7c976663e8790e5b06ca31a4a3165b11aeb89f11
  MFH:		2017Q4

Changes:
  head/misc/xfce4-weather-plugin/Makefile
  head/misc/xfce4-weather-plugin/files/
  head/misc/xfce4-weather-plugin/files/patch-panel-plugin_weather.c
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2017-10-11 07:24:53 UTC 
I committed the patch to head.

Thanks for providing it!

I also noticed this looks based on an upstream commit which we are cherry picking.

When providing patches based on upstream commit cherry pick could you provide a reference to it so it's clear we are just following what upstream is doing and our patches will be integrated anyway in a future version.

Thanks again!
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-10-23 13:23:01 UTC 
A commit references this bug:

Author: madpilot
Date: Mon Oct 23 13:22:31 UTC 2017
New revision: 452708
URL: https://svnweb.freebsd.org/changeset/ports/452708

Log:
  MFH: r451735

  Import xfce4-weather-plugin upstream patch required to make location
  search work after external site added additional requirement.

  PR:		222909
  Submitted by:	Olivier Duchateau <duchateau.olivier@gmail.com>
  Obtained from:	https://git.xfce.org/panel-plugins/xfce4-weather-plugin/commit/?id=7c976663e8790e5b06ca31a4a3165b11aeb89f11

  Approved by:	ports-secteam (swills)

Changes:
_U  branches/2017Q4/
  branches/2017Q4/misc/xfce4-weather-plugin/Makefile
  branches/2017Q4/misc/xfce4-weather-plugin/files/
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2017-10-23 13:25:23 UTC 
Merged. Thanks!