Created attachment 187069 [details] Test script to demonstrate failure of bsdinstall(8) to format efi partitions as msdosfs bsdinstall(8) doesn't properly format partitions of type efi when using scriptedpart. To produce the issue: - Start an install (I used PXE and mfsroot, but should work booting from install CD) on a physical or virtual host with a blank disk (no pre-existing gpart partition tables. - drop to a command prompt to run bsdinstall(8) - define/export a PARTITIONS variable containing a disk layout that defines a GPT disk with, at least, a freebsd-boot partition, an efi partition, and a freebsd-ufs partition - execute /usr/sbin/bsdinstall scriptedpart ${PARTITIONS} (the efi partition will show "failed") - execute /usr/sbin/bsdinstall mount (the mount_msdosfs command will fail with an invalid argument) efi partitions should be formatted with /sbin/newfs_msdos the same way freebsd-ufs is formatted with newfs(8). I think the comparison at line 170 of /usr/src/usr.sbin/bsdinstall/partedit/gpart_ops.c may be failing? The script I tested with is attached.
Changing the efi partition, in the definition of the PARTITIONS variable, to freebsd-ufs results in successful completion, but it can't be used for UEFI until the partition type is changed and properly formatted.
This is fixed in -CURRENT and changes will be MFC'ed shortly.
batch change: For bugs that match the following - Status Is In progress AND - Untouched since 2018-01-01. AND - Affects Base System OR Documentation DO: Reset to open status. Note: I did a quick pass but if you are getting this email it might be worthwhile to double check to see if this bug ought to be closed.
I think this has been fixed in all currently supported releases.
Closing as fixed, according to comments from nwhitehorn and pstef above.