Bug 222975 - www/rt44 does not install SQL files when built without DOCS
Summary: www/rt44 does not install SQL files when built without DOCS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Matthew Seaman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-13 11:09 UTC by Thomas Steen Rasmussen / Tykling
Modified: 2017-10-16 05:19 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (mikael)


Attachments
patch (21.80 KB, patch)
2017-10-13 19:44 UTC, Mikael Urankar
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Steen Rasmussen / Tykling 2017-10-13 11:09:36 UTC
When building www/rt44 with NO_DOCS the .sql files for database upgrades are not installed. Since they are not documentation but essential for upgrading a running RT instance I propose changing this so they always get installed.

Thanks.
Comment 1 Mikael Urankar freebsd_committer freebsd_triage 2017-10-13 11:46:25 UTC
similar to bug #220278

I'll prepare a patch
Comment 2 Mikael Urankar freebsd_committer freebsd_triage 2017-10-13 19:44:57 UTC
Created attachment 187149 [details]
patch

Can you try the attached patch:
Install files required to update DB schema irrespective of the setting
of the DOCS option (similar to ports r447102)
Use some options-helpers features (similar to ports r446774)
Reduce diff with www/rt42/Makefile

Do I need to bump portrevision?
Comment 3 Matthew Seaman freebsd_committer freebsd_triage 2017-10-15 10:54:36 UTC
Yes, you will need to bump the PORTREVISION -- no need to submit a new diff though: I'll handle doing that bit.
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-10-16 05:15:00 UTC
A commit references this bug:

Author: matthew
Date: Mon Oct 16 05:14:38 UTC 2017
New revision: 452170
URL: https://svnweb.freebsd.org/changeset/ports/452170

Log:
  Always install SQL schema files irrespective of the setting of the
  DOCS option.

  Make increased use of options helpers to reduce the diff against
  www/rt42

  PR:		222975
  Submitted by:	mikael.urankar@gmail.com (maintainer)
  Reported by:	thomas@gibfest.dk

Changes:
  head/www/rt44/Makefile
  head/www/rt44/pkg-plist
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-10-16 05:19:06 UTC
A commit references this bug:

Author: matthew
Date: Mon Oct 16 05:18:40 UTC 2017
New revision: 452171
URL: https://svnweb.freebsd.org/changeset/ports/452171

Log:
  Bump PORTREVISION, forgotten in previous commit.

  PR:		222975

Changes:
  head/www/rt44/Makefile
Comment 6 Matthew Seaman freebsd_committer freebsd_triage 2017-10-16 05:19:42 UTC
Committed, thanks!