Bug 223029 - multimedia/mpv: Add Wayland option
Summary: multimedia/mpv: Add Wayland option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Carlos J. Puga Medina
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-15 13:53 UTC by Greg V
Modified: 2017-10-15 16:03 UTC (History)
0 users

See Also:
cpm: maintainer-feedback+


Attachments
mpv-wayland.patch (1.22 KB, patch)
2017-10-15 13:53 UTC, Greg V
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg V 2017-10-15 13:53:48 UTC
Created attachment 187194 [details]
mpv-wayland.patch

This patch adds a WAYLAND option.

Tested on the rootston compositor (https://github.com/swaywm/wlroots).
Comment 1 Carlos J. Puga Medina freebsd_committer 2017-10-15 14:43:18 UTC
(In reply to Greg V from comment #0)

You forgot to remove --disable-wayland from CONFIGURE_ARGS.

Thanks for the patch!
Comment 2 Carlos J. Puga Medina freebsd_committer 2017-10-15 14:49:25 UTC
Have you tried to enable Wayland backend?

Add this line in mpv/Makefile

WAYLAND_LIB_DEPENDS= libwayland-egl.so:graphics/mesa-libs

Be sure that you have enabled Wayland support in graphics/mesa-libs
Comment 3 Greg V 2017-10-15 15:25:04 UTC
(In reply to Carlos J. Puga Medina from comment #2)
Even without listing libwayland-egl.so in the makefile, it works on Wayland (rootston compositor running directly on KMS), with vo=opengl.

vo=wayland is a shared memory based fallback for systems without OpenGL (like vo=x11) and it does not work on my machine. It's probably Linux specific.
Comment 4 commit-hook freebsd_committer 2017-10-15 16:01:44 UTC
A commit references this bug:

Author: cpm
Date: Sun Oct 15 16:00:45 UTC 2017
New revision: 452155
URL: https://svnweb.freebsd.org/changeset/ports/452155

Log:
  multimedia/mpv: Add WAYLAND option

  - Drop --disable-wayland from CONFIGURE_ARGS
  - Bump PORTREVISION

  PR:		223029
  Submitted by:	Greg V <greg@unrelenting.technology>

Changes:
  head/multimedia/mpv/Makefile
Comment 5 Carlos J. Puga Medina freebsd_committer 2017-10-15 16:03:03 UTC
Committed with minor changes, thanks!